Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ungrammatical dots from the error index. #32447

Merged
merged 1 commit into from
Mar 26, 2016

Conversation

nodakai
Copy link
Contributor

@nodakai nodakai commented Mar 23, 2016

They were probably meant as a shorthand for omitted code.

Part of #32446 but there should be a separate fix for the issue.

They were probably meant as a shorthand for omitted code.

Part of rust-lang#32446 but there should be a separate fix for the issue.

Signed-off-by: NODA, Kai <nodakai@gmail.com>
@rust-highfive
Copy link
Collaborator

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

@nodakai
Copy link
Contributor Author

nodakai commented Mar 24, 2016

@Manishearth any comments?

@Manishearth
Copy link
Member

@bors r+

In general IMO this is okay, but since you have a PR let's merge it

@bors
Copy link
Contributor

bors commented Mar 24, 2016

📌 Commit 0950dc3 has been approved by Manishearth

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2016
Remove ungrammatical dots from the error index.

They were probably meant as a shorthand for omitted code.

Part of rust-lang#32446 but there should be a separate fix for the issue.
bors added a commit that referenced this pull request Mar 26, 2016
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2016
Remove ungrammatical dots from the error index.

They were probably meant as a shorthand for omitted code.

Part of rust-lang#32446 but there should be a separate fix for the issue.
bors added a commit that referenced this pull request Mar 26, 2016
Rollup of 11 pull requests

- Successful merges: #32131, #32199, #32257, #32325, #32435, #32447, #32448, #32456, #32469, #32476, #32482
- Failed merges: #32240
@bors bors merged commit 0950dc3 into rust-lang:master Mar 26, 2016
@nodakai nodakai deleted the dots-in-err-idx branch March 26, 2016 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants