make available monomorphizations shared by CGU #32469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current setup means that all generics are local to a codegen-unit, which means massive duplication.
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @eddyb |
|
Nice small diff. Also I wonder if this is responsible for CGU's diminishing returns (cc @alexcrichton). |
|
📌 Commit 13877ac has been approved by |
|
Has this always been this way? |
|
Oh wow, this does seem surprising! Are monomorphizations available to other codgen units though? Basically do we make the symbols public? This'll end up making binaries a little larger if so (I'm not sure how much larger, though), but perhaps worth it? |
bors
added a commit
that referenced
this pull request
Mar 26, 2016
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 26, 2016
make available monomorphizations shared by CGU The current setup means that all generics are local to a codegen-unit, which means massive duplication.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup means that all generics are local to a codegen-unit,
which means massive duplication.