Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update casting-between-types.md #33032

Merged
merged 1 commit into from
Apr 17, 2016
Merged

Update casting-between-types.md #33032

merged 1 commit into from
Apr 17, 2016

Conversation

kindlychung
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Manishearth
Copy link
Member

@bors r+ rollup

thanks!

@bors
Copy link
Contributor

bors commented Apr 16, 2016

📌 Commit 6c93c92 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Apr 16, 2016

⌛ Testing commit 6c93c92 with merge c8d942e...

@bors
Copy link
Contributor

bors commented Apr 16, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@kindlychung
Copy link
Contributor Author

Strange. It's a mardown file, how could that break the build? 💭

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Apr 16, 2016 •
edited
Loading

@kindlychung: Some tests have "random" failures.

@alexcrichton
Copy link
Member

@bors: retry

On Sat, Apr 16, 2016 at 10:22 AM, Guillaume Gomez notifications@github.com
wrote:

@kindlychung https://github.com/kindlychung: Some tests have random
failures.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#33032 (comment)

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2016
@Manishearth
Rollup merge of rust-lang#33032 - kindlychung:patch-3, r=Manishearth
43c23e5 
Update casting-between-types.md
@Manishearth Manishearth mentioned this pull request Apr 17, 2016
Merged
bors added a commit that referenced this pull request Apr 17, 2016
@bors
Auto merge of #33049 - Manishearth:rollup, r=Manishearth
a626400 
Rollup of 10 pull requests

- Successful merges: #31441, #32956, #33003, #33022, #33023, #33032, #33039, #33044, #33045, #33046
- Failed merges:
@bors bors merged commit 6c93c92 into rust-lang:master Apr 17, 2016
@kindlychung kindlychung deleted the patch-3 branch April 17, 2016 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kindlychung @rust-highfive @Manishearth @bors @GuillaumeGomez @alexcrichton