syntax: Parse import prefixes as paths #33044

petrochenkov · 2016-04-17T01:14:17Z

r? @eddyb
(This partially intersects with #33041)

eddyb · 2016-04-17T01:24:11Z

src/libsyntax/parse/parser.rs

@@ -81,6 +81,8 @@ type ItemInfo = (Ident, ItemKind, Option<Vec<Attribute> >);
 pub enum PathParsingMode {
    /// A path with no type parameters; e.g. `foo::bar::Baz`
    NoTypesAllowed,


Is this used anymore at all?

I removed all existing uses in #33041, but a new one is introduced in #32875
Merging these two variants into one with ImportPrefix's semantics does no harm, I guess. I'll do it as a part of #33041

eddyb · 2016-04-17T02:21:32Z

@bors r+

bors · 2016-04-17T02:21:33Z

📌 Commit e7bc939 has been approved by eddyb

@eddyb

syntax: Parse import prefixes as paths Fixes rust-lang#10415 r? @eddyb (This partially intersects with rust-lang#33041)

Rollup of 10 pull requests - Successful merges: #31441, #32956, #33003, #33022, #33023, #33032, #33039, #33044, #33045, #33046 - Failed merges:

syntax: Parse import prefixes as paths

e7bc939

rust-highfive assigned eddyb Apr 17, 2016

eddyb reviewed Apr 17, 2016
View reviewed changes

Manishearth mentioned this pull request Apr 17, 2016

Rollup of 10 pull requests #33049

Merged

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2016

Rollup merge of rust-lang#33044 - petrochenkov:prefix, r=eddyb

02e40d9

syntax: Parse import prefixes as paths Fixes rust-lang#10415 r? @eddyb (This partially intersects with rust-lang#33041)

bors added a commit that referenced this pull request Apr 17, 2016

Auto merge of #33049 - Manishearth:rollup, r=Manishearth

a626400

Rollup of 10 pull requests - Successful merges: #31441, #32956, #33003, #33022, #33023, #33032, #33039, #33044, #33045, #33046 - Failed merges:

bors merged commit e7bc939 into rust-lang:master Apr 17, 2016

jseyfried mentioned this pull request Apr 27, 2016

save-analysis doesn't dump information about glob imports #33213

Closed

petrochenkov mentioned this pull request May 7, 2016

foo.bar: should expected : #33455

Closed

petrochenkov deleted the prefix branch September 21, 2016 19:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

syntax: Parse import prefixes as paths #33044

syntax: Parse import prefixes as paths #33044

petrochenkov commented Apr 17, 2016

eddyb Apr 17, 2016

petrochenkov Apr 17, 2016

eddyb commented Apr 17, 2016

bors commented Apr 17, 2016

syntax: Parse import prefixes as paths #33044

syntax: Parse import prefixes as paths #33044

Conversation

petrochenkov commented Apr 17, 2016

eddyb Apr 17, 2016

Choose a reason for hiding this comment

petrochenkov Apr 17, 2016

Choose a reason for hiding this comment

eddyb commented Apr 17, 2016

bors commented Apr 17, 2016