E0269: add suggestion to check for trailing semicolons #33324
Merged
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jroesch (rust_highfive has picked a reviewer for you, use r? to override) |
| returning an appropriate value or panicking if necessary. Check if you need | ||
| to remove a semicolon from the last expression, like in this case: | ||
|
|
||
| ```compile_fail |
There was a problem hiding this comment.
Please replace "compile_fail" by "ignore" please.
|
Thanks for your work! Please replace and squash. Then it's good to get merged! |
In situations where the value of the last expression must be inferred, rustc will not emit the "you might need to remove the semicolon" warning, so at least note this in the extended description. Fixes: rust-lang#30497
|
r=me @steveklabnik |
|
@bors r=GuillaumeGomez |
|
📌 Commit 0e89f55 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 2, 2016
…Gomez E0269: add suggestion to check for trailing semicolons In situations where the value of the last expression must be inferred, rustc will not emit the "you might need to remove the semicolon" warning, so at least note this in the extended description. Fixes: rust-lang#30497
bors
added a commit
that referenced
this pull request
May 2, 2016
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 3, 2016
…Gomez E0269: add suggestion to check for trailing semicolons In situations where the value of the last expression must be inferred, rustc will not emit the "you might need to remove the semicolon" warning, so at least note this in the extended description. Fixes: rust-lang#30497
bors
added a commit
that referenced
this pull request
May 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations where the value of the last expression must be inferred,
rustc will not emit the "you might need to remove the semicolon" warning,
so at least note this in the extended description.
Fixes: #30497