rustc: Handle concurrent create_dir requests
#33332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
| match fs::create_dir(path) { | ||
| Ok(()) => return, | ||
| Err(ref e) if e.kind() == io::ErrorKind::AlreadyExists => return Ok(()), | ||
| Err(ref e) if e.kind() == io::ErrorKind::NotFound => {} |
There was a problem hiding this comment.
When do you get ErrorKind::NotFound? If the parent doesn't exist?
There was a problem hiding this comment.
Yeah that's the case where this is emulating create_dir_all instead of just create_dir, and if you create /foo/bar/baz but /foo/bar doesn't exist you'll get EEXIST (not found)
|
lgtm, r=me when it's compile clean. |
The compiler created a directory as part of `-Z incremental` but that may be hierarchically used concurrently so we need to protect ourselves against that.
alexcrichton
force-pushed
the
handle-more-races
branch
from
b0be4d4 to
71e6329
Compare
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 2, 2016
…ichaelwoerister rustc: Handle concurrent `create_dir` requests The compiler created a directory as part of `-Z incremental` but that may be hierarchically used concurrently so we need to protect ourselves against that.
bors
added a commit
that referenced
this pull request
May 2, 2016
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 3, 2016
…ichaelwoerister rustc: Handle concurrent `create_dir` requests The compiler created a directory as part of `-Z incremental` but that may be hierarchically used concurrently so we need to protect ourselves against that.
bors
added a commit
that referenced
this pull request
May 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler created a directory as part of
-Z incrementalbut that may behierarchically used concurrently so we need to protect ourselves against that.