Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accessor methods to DiagnosticBuilder #33484

Merged
merged 1 commit into from
May 9, 2016
Merged

Add accessor methods to DiagnosticBuilder #33484

merged 1 commit into from
May 9, 2016

Conversation

murarth
Copy link
Contributor

@murarth murarth commented May 7, 2016

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@murarth
Copy link
Contributor Author

murarth commented May 7, 2016

I use a custom emitter in rusti to check error messages for things like open delimiters in input. It's broken with no way to access the message field.

@brson
Copy link
Contributor

brson commented May 8, 2016

@bors r+

@bors
Copy link
Contributor

bors commented May 8, 2016

📌 Commit 0d5f474 has been approved by brson

@nrc
Copy link
Member

nrc commented May 8, 2016

I would prefer to make the fields public if you need them to be, rather than add accessors, but fine by me either way.

@Manishearth Manishearth mentioned this pull request May 8, 2016
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request May 8, 2016
@Manishearth
Rollup merge of rust-lang#33484 - murarth:diagnostic-builder-fields, …
6249772 
…r=brson

Add accessor methods to DiagnosticBuilder
bors added a commit that referenced this pull request May 8, 2016
@bors
Auto merge of #33501 - Manishearth:rollup, r=Manishearth
6d369a8 
Rollup of 9 pull requests

- Successful merges: #32900, #33129, #33365, #33383, #33474, #33478, #33480, #33484, #33493
- Failed merges: #33360
@bors
Copy link
Contributor

bors commented May 9, 2016

⌛ Testing commit 0d5f474 with merge 0cc9097...

bors added a commit that referenced this pull request May 9, 2016
@bors
Auto merge of #33484 - murarth:diagnostic-builder-fields, r=brson
0cc9097 
Add accessor methods to DiagnosticBuilder
@bors
Copy link
Contributor

bors commented May 9, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

@bors bors merged commit 0d5f474 into rust-lang:master May 9, 2016
@murarth murarth deleted the diagnostic-builder-fields branch May 9, 2016 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@murarth @rust-highfive @brson @bors @nrc