Librustc_resolve diagnostics fixes #33493
Conversation
| } | ||
| ``` | ||
|
|
||
|
|
|
cc #32777 |
| let x = (0,2); | ||
| match x { | ||
| (0, ref y) | (y, 0) => { /* use y */} // error: variable `y` is bound with | ||
| // different mode in pattern #2 than |
There was a problem hiding this comment.
It shouldn't be aligned with "error:". If it is too long, write it to next line.
|
☔ The latest upstream changes (presumably #33494) made this pull request unmergeable. Please resolve the merge conflicts. |
|
addressed |
| Example of erroneous code: | ||
|
|
||
| ```compile_fail | ||
| let x = (0,2); |
There was a problem hiding this comment.
You put a whitespace after the comma everywhere else. I think to be consistent you should put it here as well.
|
Thanks! r=me |
|
@bors r=GuillaumeGomez |
|
📌 Commit a795419 has been approved by |
…omez Librustc_resolve diagnostics fixes r? @GuillaumeGomez
| ``` | ||
| let x = (0, 2); | ||
| match x { | ||
| (0, ref y) | (ref y, 0) => { /* use y */} |
There was a problem hiding this comment.
http://buildbot.rust-lang.org/builders/auto-linux-64-opt-rustbuild/builds/1038/steps/test/logs/stdio <- it looks like this fails the rollup
There was a problem hiding this comment.
That's an ICE. I already filed it. We need to add "ignore" on this one or to find a workaround...
There was a problem hiding this comment.
Fixed. r?
(I didn't mention a bug number here since this is supposed to be read by the user. I've left a note on the ICE bug.)
|
@bors: r- |
|
Seems fixed. cc @steveklabnik |
|
@bors r+ p=20 |
|
📌 Commit 84843b7 has been approved by |
|
@bors rollup p=0 oops |
r? @GuillaumeGomez