Partially stabilize RFC 1506 "Clarify relationships between ADTs" #36868
Conversation
brson
added
relnotes
|
cc @rust-lang/lang -- thoughts on stabilizing |
|
Should this have an FCP cycle? I'm still in favour of the change but it does not seem like a no-brainer feature to me - it still gives me pause that braced structs can match tuple structs in patterns. |
|
@nrc I was thinking it probably should, yes. |
Turn compatibility lint `match_of_unit_variant_via_paren_dotdot` into a hard error The lint was introduced 10 months ago and made deny-by-default 7 months ago. In case someone is still using it, #36868 contains a stable replacement. r? @nikomatsakis
|
ping, is this just waiting for the FCP on an issue to close? |
|
Yes, waiting for FCP. |
|
@petrochenkov so FCP is over, care to rebase? |
|
Rebased. |
|
@bors r+ |
|
📌 Commit baf9f33 has been approved by |
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #36843) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r=nikomatsakis |
|
📌 Commit ab5ba04 has been approved by |
Partially stabilize RFC 1506 "Clarify relationships between ADTs"
Lifted restrictions on tuple structs/variants are stabilized, i.e. `S{..}` can be used with any structs and empty tuple structs are permitted without feature gate.
Numeric fields in struct expressions/patterns `S { 0: a, 1: b }` are **NOT** stabilized.
This was implemented 1.5 months ago in Rust 1.12, but this is a tiny technical change that could probably go even without RFC/stabilization period.
cc rust-lang#35626 rust-lang#36871
r? @nikomatsakis
Lifted restrictions on tuple structs/variants are stabilized, i.e.
S{..}can be used with any structs and empty tuple structs are permitted without feature gate.Numeric fields in struct expressions/patterns
S { 0: a, 1: b }are NOT stabilized.This was implemented 1.5 months ago in Rust 1.12, but this is a tiny technical change that could probably go even without RFC/stabilization period.
cc #35626 #36871
r? @nikomatsakis