Turn compatibility lint match_of_unit_variant_via_paren_dotdot into a hard error
#36871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Started crater run comparing 1d64acd and 982770d01b44490666f475ab5caa7f157ea0dfc8. |
|
☔ The latest upstream changes (presumably #36814) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Crater report: https://gist.github.com/nikomatsakis/ac9e9e1abf4cf42c398680ac5afa3a74
|
|
ring-0.4.3 - |
|
@bors r+ |
|
📌 Commit b3cb8f6 has been approved by |
|
Seems ok. |
bors
added a commit
that referenced
this pull request
Oct 11, 2016
Turn compatibility lint `match_of_unit_variant_via_paren_dotdot` into a hard error The lint was introduced 10 months ago and made deny-by-default 7 months ago. In case someone is still using it, #36868 contains a stable replacement. r? @nikomatsakis
|
Just restarted buildbot, but this passed almost all tests, so merging. |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Nov 9, 2016
Partially stabilize RFC 1506 "Clarify relationships between ADTs"
Lifted restrictions on tuple structs/variants are stabilized, i.e. `S{..}` can be used with any structs and empty tuple structs are permitted without feature gate.
Numeric fields in struct expressions/patterns `S { 0: a, 1: b }` are **NOT** stabilized.
This was implemented 1.5 months ago in Rust 1.12, but this is a tiny technical change that could probably go even without RFC/stabilization period.
cc rust-lang#35626 rust-lang#36871
r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint was introduced 10 months ago and made deny-by-default 7 months ago.
In case someone is still using it, #36868 contains a stable replacement.
r? @nikomatsakis