-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct a typo in procedural macros chapter of the Book. #39847
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@@ -169,7 +169,7 @@ So this is where quotes comes in. The `ast` argument is a struct that gives us | |||
a representation of our type (which can be either a `struct` or an `enum`). | |||
Check out the [docs](https://docs.rs/syn/0.10.5/syn/struct.MacroInput.html), | |||
there is some useful information there. We are able to get the name of the | |||
type using `ast.ident`. The `quote!` macro let's us write up the Rust code | |||
type using `ast.ident`. The `quote!` macro let us write up the Rust code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be "... lets us write ..." since 'macro' is singular.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed! I pushed a fixup commit.
Thanks! @bors r+ rollup |
📌 Commit 36b00cf has been approved by |
Correct a typo in procedural macros chapter of the Book. A simple and short correction for procedural macros chapter of the Rust Programming Language Book.
Correct a typo in procedural macros chapter of the Book. A simple and short correction for procedural macros chapter of the Rust Programming Language Book.
Correct a typo in procedural macros chapter of the Book. A simple and short correction for procedural macros chapter of the Rust Programming Language Book.
Correct a typo in procedural macros chapter of the Book. A simple and short correction for procedural macros chapter of the Rust Programming Language Book.
A simple and short correction for procedural macros chapter of the Rust Programming Language Book.