Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a typo in procedural macros chapter of the Book. #39847

Merged
merged 2 commits into from
Feb 18, 2017
Merged

Correct a typo in procedural macros chapter of the Book. #39847

merged 2 commits into from
Feb 18, 2017

Conversation

CBenoit
Copy link
Contributor

@CBenoit CBenoit commented Feb 15, 2017

A simple and short correction for procedural macros chapter of the Rust Programming Language Book.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -169,7 +169,7 @@ So this is where quotes comes in. The `ast` argument is a struct that gives us
a representation of our type (which can be either a `struct` or an `enum`).
Check out the [docs](https://docs.rs/syn/0.10.5/syn/struct.MacroInput.html),
there is some useful information there. We are able to get the name of the
type using `ast.ident`. The `quote!` macro let's us write up the Rust code
type using `ast.ident`. The `quote!` macro let us write up the Rust code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "... lets us write ..." since 'macro' is singular.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! I pushed a fixup commit.

@frewsxcv
Copy link
Member

Thanks! @bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 16, 2017

📌 Commit 36b00cf has been approved by frewsxcv

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 17, 2017
Correct a typo in procedural macros chapter of the Book.

A simple and short correction for procedural macros chapter of the Rust Programming Language Book.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 17, 2017
Correct a typo in procedural macros chapter of the Book.

A simple and short correction for procedural macros chapter of the Rust Programming Language Book.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 17, 2017
Correct a typo in procedural macros chapter of the Book.

A simple and short correction for procedural macros chapter of the Rust Programming Language Book.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 18, 2017
Correct a typo in procedural macros chapter of the Book.

A simple and short correction for procedural macros chapter of the Rust Programming Language Book.
bors added a commit that referenced this pull request Feb 18, 2017
Rollup of 5 pull requests

- Successful merges: #39847, #39862, #39898, #39904, #39928
- Failed merges:
@bors bors merged commit 36b00cf into rust-lang:master Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants