Rollup of 5 pull requests #39933
Merged
Rollup of 5 pull requests #39933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
Feb 18, 2017
GuillaumeGomez
commented
- Successful merges: Correct a typo in procedural macros chapter of the Book. #39847, Fix wording in LocalKey documentation #39862, code order tweak #39898, Fixup String::split_off documentation #39904, Add missing urls for env functions #39928
- Failed merges:
1. Clarify that `String::split_off` returns one string and modifies self in-place. The documentation implied that it returns two new strings. 2. Make the documentation mirror `Vec::split_off`.
Correct a typo in procedural macros chapter of the Book. A simple and short correction for procedural macros chapter of the Rust Programming Language Book.
…illaumeGomez Fix wording in LocalKey documentation Fixes rust-lang#39841 r? @GuillaumeGomez
code order tweak
… r=frewsxcv Fixup String::split_off documentation 1. Clarify that `String::split_off` returns one string and modifies self in-place. The documentation implied that it returns two new strings. 2. Make the documentation mirror `Vec::split_off`.
…wsxcv Add missing urls for env functions r? @frewsxcv
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit 98c2cf2 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.