Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds rust-windbg.cmd script #39983

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Adds rust-windbg.cmd script #39983

merged 1 commit into from
Apr 26, 2017

Conversation

AndrewGaspar
Copy link
Contributor

Adds rust-gdb/rust-lldb equivalent for windbg that loads the Rust .natvis files on start.

This change modifies the bootstrap code to add rust-windbg to bin and the .natvis files to lib/rustlib/etc.

Example usage from cmd or PowerShell:

rust-windbg -c "bu rs_f442289d74765418!rs::main;g" target\debug\rs.exe

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned nikomatsakis Feb 21, 2017
@AndrewGaspar AndrewGaspar mentioned this pull request Mar 12, 2017
Merged
@alexcrichton
Copy link
Member

Sorry for the delay here @AndrewGaspar! I'll try to ping @brson in person soon to help move this along.

@arielb1 arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2017
@alexcrichton
Copy link
Member

Haven't forgotten this, @brson will be back next week from China

@brson
Copy link
Contributor

brson commented Apr 24, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2017

📌 Commit 9737ee2 has been approved by brson

@brson brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 24, 2017
@brson
Copy link
Contributor

brson commented Apr 24, 2017

cc @vadimcn does this look reasonable to you?

@bors
Copy link
Contributor

bors commented Apr 24, 2017

🔒 Merge conflict

@alexcrichton
Copy link
Member

@bors: r=brson

@bors
Copy link
Contributor

bors commented Apr 24, 2017

📌 Commit 70e6739 has been approved by brson

@bors
Copy link
Contributor

bors commented Apr 25, 2017

⌛ Testing commit 70e6739 with merge 10f481d...

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 25, 2017
@frewsxcv
Rollup merge of rust-lang#39983 - AndrewGaspar:rust-windbg, r=brson
2ac3d6a 
Adds rust-windbg.cmd script

Adds rust-gdb/rust-lldb equivalent for windbg that loads the Rust .natvis files on start.

This change modifies the bootstrap code to add rust-windbg to bin and the .natvis files to lib/rustlib/etc.

Example usage from cmd or PowerShell:
```
rust-windbg -c "bu rs_f442289d74765418!rs::main;g" target\debug\rs.exe
```
@frewsxcv frewsxcv mentioned this pull request Apr 25, 2017
Closed
@frewsxcv
Copy link
Member

@bors retry prioritizing rollup

@alexcrichton
Copy link
Member

@bors: retry

@arielb1 arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
Rollup merge of rust-lang#39983 - AndrewGaspar:rust-windbg, r=brson
7a87593 
Adds rust-windbg.cmd script

Adds rust-gdb/rust-lldb equivalent for windbg that loads the Rust .natvis files on start.

This change modifies the bootstrap code to add rust-windbg to bin and the .natvis files to lib/rustlib/etc.

Example usage from cmd or PowerShell:
```
rust-windbg -c "bu rs_f442289d74765418!rs::main;g" target\debug\rs.exe
```
@arielb1 arielb1 mentioned this pull request Apr 25, 2017
Closed
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
Rollup merge of rust-lang#39983 - AndrewGaspar:rust-windbg, r=brson
c4db48c 
Adds rust-windbg.cmd script

Adds rust-gdb/rust-lldb equivalent for windbg that loads the Rust .natvis files on start.

This change modifies the bootstrap code to add rust-windbg to bin and the .natvis files to lib/rustlib/etc.

Example usage from cmd or PowerShell:
```
rust-windbg -c "bu rs_f442289d74765418!rs::main;g" target\debug\rs.exe
```
@arielb1 arielb1 mentioned this pull request Apr 25, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 26, 2017
@frewsxcv
Rollup merge of rust-lang#39983 - AndrewGaspar:rust-windbg, r=brson
27fbe8c 
Adds rust-windbg.cmd script

Adds rust-gdb/rust-lldb equivalent for windbg that loads the Rust .natvis files on start.

This change modifies the bootstrap code to add rust-windbg to bin and the .natvis files to lib/rustlib/etc.

Example usage from cmd or PowerShell:
```
rust-windbg -c "bu rs_f442289d74765418!rs::main;g" target\debug\rs.exe
```
@frewsxcv frewsxcv mentioned this pull request Apr 26, 2017
Merged
bors added a commit that referenced this pull request Apr 26, 2017
@bors
Auto merge of #41551 - frewsxcv:rollup, r=frewsxcv
4512424 
Rollup of 9 pull requests

- Successful merges: #39983, #41442, #41463, #41500, #41518, #41527, #41528, #41530, #41535
- Failed merges:
@bors bors merged commit 70e6739 into rust-lang:master Apr 26, 2017
ehuss added a commit to ehuss/rust that referenced this pull request Jan 13, 2022
@ehuss
Remove duplicate rust-lang#39983. It was part of 1.19.
73cb56e
ehuss added a commit to ehuss/rust that referenced this pull request Jan 14, 2022
@ehuss
Remove duplicate rust-lang#39983. It was part of 1.19.
c1526c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@AndrewGaspar @rust-highfive @alexcrichton @brson @bors @frewsxcv @nikomatsakis @arielb1