Rollup of 9 pull requests #41522
Rollup of 9 pull requests #41522
Conversation
Also spell out that read and write operations should be retried on `ErrorKind::Interrupted` errors. Fixes rust-lang#38494.
Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
Suppress warning introduced by rust-lang/cargo#3841.
ASan and TSan are supported on macOS, and this commit enables their support. The sanitizers are always built as *.dylib on Apple platforms, so they cannot be statically linked into the corresponding `rustc_?san.rlib`. The dylibs are directly copied to `lib/rustlib/x86_64-apple-darwin/lib/` instead. Note, although Xcode also ships with their own copies of ASan/TSan dylibs, we cannot use them due to version mismatch. There is a caveat: the sanitizer libraries are linked as @rpath, so the user needs to additionally pass `-C rpath`: rustc -Z sanitizer=address -C rpath file.rs ^~~~~~~~ Otherwise there will be a runtime error: dyld: Library not loaded: @rpath/libclang_rt.asan_osx_dynamic.dylib Referenced from: /path/to/executable Reason: image not found Abort trap: 6 The next commit includes a temporary change in compiler to force the linker to emit a usable @rpath.
Adds rust-windbg.cmd script Adds rust-gdb/rust-lldb equivalent for windbg that loads the Rust .natvis files on start. This change modifies the bootstrap code to add rust-windbg to bin and the .natvis files to lib/rustlib/etc. Example usage from cmd or PowerShell: ``` rust-windbg -c "bu rs_f442289d74765418!rs::main;g" target\debug\rs.exe ```
Implement Vec::splice and String::splice (RFC 1432) RFC: rust-lang/rfcs#1432, tracking issue: rust-lang#32310 A rebase of rust-lang#32355 with a few more tests. Let me know if you have any ideas for more tests. cc @SimonSapin
…chton Support AddressSanitizer and ThreadSanitizer on x86_64-apple-darwin [ASan](https://clang.llvm.org/docs/AddressSanitizer.html#supported-platforms) and [TSan](https://clang.llvm.org/docs/ThreadSanitizer.html#supported-platforms) are supported on macOS, and this commit enables their support. The sanitizers are always built as `*.dylib` on Apple platforms, so they cannot be statically linked into the corresponding `rustc_?san.rlib`. The dylibs are directly copied to `lib/rustlib/x86_64-apple-darwin/lib/` instead. Note, although Xcode also ships with their own copies of ASan/TSan dylibs, we cannot use them due to version mismatch. ---- ~~There is a caveat: the sanitizer libraries are linked as `@rpath/` (due to https://reviews.llvm.org/D6018), so the user needs to additionally pass `-C rpath`:~~ **Edit:** Passing rpath is now automatic.
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
…richton Add bootstrap support for android
Specify behavior of `write_all` for `ErrorKind::Interrupted` errors Also spell out that read and write operations should be retried on `ErrorKind::Interrupted` errors. Fixes rust-lang#38494.
Add internal accessor methods to io::{Chain, Take}.
Resolves rust-lang#29067.
use the word 'length' in Vec::len's docs Fixes rust-lang#37866
Fix a copy-paste error in `Instant::sub_duration` Fixes rust-lang#41514.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ p=10 |
|
📌 Commit c63aca0 has been approved by |
|
⌛ Testing commit c63aca0 with merge 2ae53ef... |
|
💔 Test failed - status-travis |
|
macOS-check (x86_64) stuck in |
|
@bors: retry
|
|
@bors: retry |
|
⌛ Testing commit c63aca0 with merge 03d6ff7... |
|
Even though it supposedly started 3 hours ago, Travis says "Running for 1 hr 48 min" for some builders, and "Running for 18 min" for others, this looks bad cc @rust-lang/tools |
|
Although the build was created 4 hours ago (~05:00 UTC), no jobs started until 3 hours ago. According to the raw log in https://travis-ci.org/rust-lang/rust/jobs/225486381, the oldest job started at 06:44 UTC, and finished at 09:04 UTC. (Time now is 09:30 UTC). That is, the build waited almost 2 hours on Travis. Travis has a database connectivity issue from 03:41 UTC to 04:45 UTC, so probably the response is slower when Travis is clearing the backlog esp. the macOS ones. (AppVeyor is all-green btw.) |
|
💔 Test failed - status-travis |
write_allforErrorKind::Interruptederrors #41442, Add internal accessor methods to io::{Chain, Take}. #41463, use the word 'length' in Vec::len's docs #41500, Fix a copy-paste error inInstant::sub_duration#41518