Rollup of 8 pull requests #40318
Closed
Rollup of 8 pull requests #40318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Mar 7, 2017
steveklabnik
commented
- Successful merges: add unstable book to the bookshelf #40154, Extract nomicon to its own repo #40222, Issue #39688 - Help people find String::as_bytes() for UTF-8 #40226, Fix description of closure coercion feature #40258, clarify docs for Args and ArgsOs #40283, Fix text formatting in README #40292, Remove extra space in test description (of a mod test) #40293, Fix a typo in the docs #40316
- Failed merges:
The args() and args_os() docs include a line about how the first element is usually the program name. Include that line in the struct docs too.
…frewsxcv add unstable book to the bookshelf r? @frewsxcv @GuillaumeGomez
…xcrichton Extract nomicon to its own repo part of rust-lang#39588 same as rust-lang#40213 but for the nomicon r? @alexcrichton
Issue rust-lang#39688 - Help people find String::as_bytes() for UTF-8 Added in links for the inverse functions so people will know that as_bytes() is the inverse of from_utf8() and vice versa. ?r @steveklabnik
Fix description of closure coercion feature Thanks to @whitequark for pointing this out.
clarify docs for Args and ArgsOs The args() and args_os() docs include a line about how the first element is usually the program name. Include that line in the struct docs too.
Fix text formatting in README There was a missing backtick in the README.
Remove extra space in test description (of a mod test)
Fix a typo in the docs
|
@bors: r+ p=1 |
|
📌 Commit ed3caa3 has been approved by |
|
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit ed3caa3 with merge 2eaedce... |
|
💔 Test failed - status-travis |
|
@bors: retry seems like a spurious network error |
|
⌛ Testing commit ed3caa3 with merge 6946192... |
|
💔 Test failed - status-travis |
|
@bors: retry couldn't get packages from crates.io |
|
⌛ Testing commit ed3caa3 with merge 09f3a03... |
|
💔 Test failed - status-travis |
|
Since when do we use ruby? |
|
Regardless, seems like a spurious rubygem failure? @bors retry |
😭 We don't use ruby, it's travis stuff |
|
⌛ Testing commit ed3caa3 with merge 1fcefe8... |
|
💔 Test failed - status-travis |
|
|
@bors: retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.