Extract nomicon to its own repo #40222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
JordiPolo
reviewed
Mar 3, 2017
| @@ -18,3 +18,6 @@ | |||
| [submodule "src/liblibc"] | |||
| path = src/liblibc | |||
| url = https://github.com/rust-lang/libc.git | |||
| [submodule "src/doc/nomicon"] | |||
| path = src/doc/nomicon | |||
| url = https://github.com/rust-lang-nursery/nomicon | |||
There was a problem hiding this comment.
I wonder if this book was official part of the rust-lang, why "downgrade" it to rust-lang-nursery instead of keeping a repo in rust-lang ?
There was a problem hiding this comment.
None of us felt super strongly, but @brson said, with regards to the reference, that it needs a lot of work. The same is true for the nomicon; it still has the huge header at the top, for example.
Given that, the nursery feels appropriate, though I can see putting it in rust-lang too!
|
☔ The latest upstream changes (presumably #39917) made this pull request unmergeable. Please resolve the merge conflicts. |
steveklabnik
force-pushed
the
extract-nomicon
branch
from
2529a1e
to
4369aee
Compare
|
@alexcrichton rebased to fix the merge conflict |
|
@bors: r+ |
|
📌 Commit 4369aee has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Mar 6, 2017
…xcrichton Extract nomicon to its own repo part of rust-lang#39588 same as rust-lang#40213 but for the nomicon r? @alexcrichton
|
@bors: rollup |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Mar 7, 2017
…xcrichton Extract nomicon to its own repo part of rust-lang#39588 same as rust-lang#40213 but for the nomicon r? @alexcrichton
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 8, 2017
…xcrichton Extract nomicon to its own repo part of rust-lang#39588 same as rust-lang#40213 but for the nomicon r? @alexcrichton
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 8, 2017
…xcrichton Extract nomicon to its own repo part of rust-lang#39588 same as rust-lang#40213 but for the nomicon r? @alexcrichton
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 8, 2017
…xcrichton Extract nomicon to its own repo part of rust-lang#39588 same as rust-lang#40213 but for the nomicon r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #39588
same as #40213 but for the nomicon
r? @alexcrichton