-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added remove_item to vec.rs (#38143) #40325
Conversation
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r=alexcrichton |
📌 Commit df61719 has been approved by |
So... Now what? Is my commit gonna be in the compiler now? In the beta or nightly? |
@madseagames It first has to go through the merge queue, where the PR is tested in a few dozen configurations, and if successful, it will be in the first nightly after that. |
@eddyb that's awesome! Thanks for the help Eddy! |
Added remove_from to vec.rs (rust-lang#38143) Turns out that if you push to someone's PR branch and cause the PR to close, you lose delegation 😞. @madseagames I'm really sorry about that 😭
Added remove_from to vec.rs (rust-lang#38143) Turns out that if you push to someone's PR branch and cause the PR to close, you lose delegation 😞. @madseagames I'm really sorry about that 😭
Added remove_from to vec.rs (rust-lang#38143) Turns out that if you push to someone's PR branch and cause the PR to close, you lose delegation 😞. @madseagames I'm really sorry about that 😭
Turns out that if you push to someone's PR branch and cause the PR to close, you lose delegation 😞.
@madseagames I'm really sorry about that 😭