Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added remove_item to vec.rs (#38143) #40325

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Added remove_item to vec.rs (#38143) #40325

merged 1 commit into from
Mar 9, 2017

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Mar 7, 2017

Turns out that if you push to someone's PR branch and cause the PR to close, you lose delegation 😞.

@madseagames I'm really sorry about that 😭

@rust-highfive
Copy link
Collaborator

r? @BurntSushi

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb
Copy link
Member Author

eddyb commented Mar 7, 2017

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Mar 7, 2017

📌 Commit df61719 has been approved by alexcrichton

@eddyb eddyb mentioned this pull request Mar 7, 2017
@madseagames
Copy link
Contributor

So... Now what? Is my commit gonna be in the compiler now? In the beta or nightly?

@eddyb
Copy link
Member Author

eddyb commented Mar 7, 2017

@madseagames It first has to go through the merge queue, where the PR is tested in a few dozen configurations, and if successful, it will be in the first nightly after that.

@madseagames
Copy link
Contributor

@eddyb that's awesome! Thanks for the help Eddy!

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 8, 2017
Added remove_from to vec.rs (rust-lang#38143)

Turns out that if you push to someone's PR branch and cause the PR to close, you lose delegation 😞.

@madseagames I'm really sorry about that 😭
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 8, 2017
Added remove_from to vec.rs (rust-lang#38143)

Turns out that if you push to someone's PR branch and cause the PR to close, you lose delegation 😞.

@madseagames I'm really sorry about that 😭
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 8, 2017
Added remove_from to vec.rs (rust-lang#38143)

Turns out that if you push to someone's PR branch and cause the PR to close, you lose delegation 😞.

@madseagames I'm really sorry about that 😭
bors added a commit that referenced this pull request Mar 9, 2017
@bors bors merged commit df61719 into rust-lang:master Mar 9, 2017
@bors
Copy link
Contributor

bors commented Mar 9, 2017

⌛ Testing commit df61719 with merge 3087a1f...

@eddyb eddyb deleted the pr38143 branch March 9, 2017 13:14
@dtolnay dtolnay changed the title Added remove_from to vec.rs (#38143) Added remove_item to vec.rs (#38143) Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants