Add compile-fail tests for remaining items in whitelist and remove it #40279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
☔ The latest upstream changes (presumably #40252) made this pull request unmergeable. Please resolve the merge conflicts. |
Test copied from src/test/codegen/extern-functions.rs. Refs: rust-lang#39059
Test copied from src/test/run-pass/thread-local-extern-static.rs. Refs: rust-lang#39059
gibfahn
changed the title
No longer necessary now that the whitelist is empty. Fixes: rust-lang#39059
gibfahn
changed the title
est31
approved these changes
Mar 6, 2017
|
@bors r=est31 |
|
📌 Commit 7c88d9e has been approved by |
|
⌛ Testing commit 7c88d9e with merge ef8633d... |
|
💔 Test failed - status-travis |
|
@est31 or @petrochenkov is this error related to this PR? I think the relevant part is: Check compiletest suite=run-fail mode=run-fail (i686-apple-darwin -> i686-apple-darwin)
running 126 tests
..F.........i.................................................................................................................
failures:
---- [run-fail] run-fail/assert-as-macro.rs stdout ----
error: compilation failed!
status: exit code: 101
command: /Users/travis/build/rust-lang/rust/build/i686-apple-darwin/stage2/bin/rustc /Users/travis/build/rust-lang/rust/src/test/run-fail/assert-as-macro.rs -L /Users/travis/build/rust-lang/rust/build/i686-apple-darwin/test/run-fail --target=i686-apple-darwin -L /Users/travis/build/rust-lang/rust/build/i686-apple-darwin/test/run-fail/assert-as-macro.stage2-i686-apple-darwin.run-fail.libaux -C prefer-dynamic -o /Users/travis/build/rust-lang/rust/build/i686-apple-darwin/test/run-fail/assert-as-macro.stage2-i686-apple-darwin -Crpath -O -Lnative=/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/native/rust-test-helpers
stdout:
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
error: linking with `cc` failed: exit code: 254
|
= note: "cc" "-m32" "-L" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/stage2/lib/rustlib/i686-apple-darwin/lib" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/test/run-fail/assert-as-macro.0.o" "-o" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/test/run-fail/assert-as-macro.stage2-i686-apple-darwin" "-Wl,-dead_strip" "-nodefaultlibs" "-L" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/test/run-fail" "-L" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/test/run-fail/assert-as-macro.stage2-i686-apple-darwin.run-fail.libaux" "-L" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/native/rust-test-helpers" "-L" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/stage2/lib/rustlib/i686-apple-darwin/lib" "-L" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/stage2/lib/rustlib/i686-apple-darwin/lib" "-l" "std-de17a90db9a531ae" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/stage2/lib/rustlib/i686-apple-darwin/lib/libcompiler_builtins-417d0cd8e787f49e.rlib" "-l" "System" "-l" "pthread" "-l" "c" "-l" "m" "-Wl,-rpath,@loader_path/../../stage2/lib/rustlib/i686-apple-darwin/lib" "-Wl,-rpath,/usr/local/lib/rustlib/i686-apple-darwin/lib"
= note: ld: warning: directory not found for option '-L/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/test/run-fail/assert-as-macro.stage2-i686-apple-darwin.run-fail.libaux'
clang: error: unable to execute command: Segmentation fault: 11
clang: error: linker command failed due to signal (use -v to see invocation)
error: aborting due to previous error
------------------------------------------
thread '[run-fail] run-fail/assert-as-macro.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:2637
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
[run-fail] run-fail/assert-as-macro.rs
test result: FAILED. 124 passed; 1 failed; 1 ignored; 0 measured
thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:330
command did not execute successfully: "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/stage0-tools/i686-apple-darwin/release/compiletest" "--compile-lib-path" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/stage2/lib" "--run-lib-path" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/stage2/lib/rustlib/i686-apple-darwin/lib" "--rustc-path" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/stage2/bin/rustc" "--rustdoc-path" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/stage2/bin/rustdoc" "--src-base" "/Users/travis/build/rust-lang/rust/src/test/run-fail" "--build-base" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/test/run-fail" "--stage-id" "stage2-i686-apple-darwin" "--mode" "run-fail" "--target" "i686-apple-darwin" "--host" "i686-apple-darwin" "--llvm-filecheck" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/llvm/build/bin/FileCheck" "--nodejs" "/Users/travis/.nvm/versions/node/v6.9.1/bin/node" "--host-rustcflags" "-Crpath -O" "--target-rustcflags" "-Crpath -O -Lnative=/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/native/rust-test-helpers" "--docck-python" "/usr/local/bin/python2.7" "--lldb-python" "/usr/bin/python" "--lldb-version" "lldb-360.1.70" "--lldb-python-dir" "/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python" "--llvm-version" "3.9.1\n" "--quiet" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp" "--android-cross-path" ""
expected success, got: exit code: 101
Build completed unsuccessfully in 0:16:54
make: *** [check] Error 1 |
|
@bors: retry |
|
Did the retry happen? |
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 8, 2017
Add compile-fail tests for remaining items in whitelist and remove it Add compile-fail tests for `cfg_target_thread_local` and `unwind_attributes`, and remove the whitelist. Let me know if I should clean up the tests (or if I've done anything else wrong, this is my first contribution to rust). cc/ @est31
bors
added a commit
that referenced
this pull request
Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compile-fail tests for
cfg_target_thread_localandunwind_attributes, and remove the whitelist.Let me know if I should clean up the tests (or if I've done anything else wrong, this is my first contribution to rust).
cc/ @est31