Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reword the non-dropping of src for ptr::write{,_unaligned} #40387

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Reword the non-dropping of src for ptr::write{,_unaligned} #40387

merged 1 commit into from
Mar 17, 2017

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented Mar 9, 2017

@niconii Is it OK if I put your wording into the documentation?
CC @nagisa

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@nagisa
Copy link
Member

nagisa commented Mar 9, 2017 via email

@niconii
Copy link
Contributor

niconii commented Mar 9, 2017

Sure.

@tbu-
Copy link
Contributor Author

tbu- commented Mar 9, 2017

Documentation, so probably r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned brson Mar 9, 2017
@steveklabnik
Copy link
Member

@bors: r+ rollup

thanks ❤️

@bors
Copy link
Contributor

bors commented Mar 13, 2017

📌 Commit 13341f4 has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 14, 2017
@frewsxcv
Rollup merge of rust-lang#40387 - tbu-:pr_doc_ptr_write2, r=steveklabnik
8361757 
Reword the non-dropping of `src` for `ptr::write{,_unaligned}`

@niconii Is it OK if I put your wording into the documentation?
CC @nagisa
@frewsxcv frewsxcv mentioned this pull request Mar 14, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 14, 2017
@frewsxcv
Rollup merge of rust-lang#40387 - tbu-:pr_doc_ptr_write2, r=steveklabnik
5d36784 
Reword the non-dropping of `src` for `ptr::write{,_unaligned}`

@niconii Is it OK if I put your wording into the documentation?
CC @nagisa
@frewsxcv frewsxcv mentioned this pull request Mar 14, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 15, 2017
@frewsxcv
Rollup merge of rust-lang#40387 - tbu-:pr_doc_ptr_write2, r=steveklabnik
8ab12d7 
Reword the non-dropping of `src` for `ptr::write{,_unaligned}`

@niconii Is it OK if I put your wording into the documentation?
CC @nagisa
@frewsxcv frewsxcv mentioned this pull request Mar 15, 2017
Closed
bors added a commit that referenced this pull request Mar 15, 2017
@bors
Auto merge of #40544 - frewsxcv:rollup, r=frewsxcv
b5ccda0 
Rollup of 18 pull requests

- Successful merges: #40387, #40433, #40452, #40456, #40457, #40463, #40466, #40467, #40495, #40496, #40497, #40500, #40503, #40505, #40512, #40514, #40517, #40520
- Failed merges:
bors added a commit that referenced this pull request Mar 16, 2017
@bors
Auto merge of #40544 - frewsxcv:rollup, r=frewsxcv
d62dea5 
Rollup of 18 pull requests

- Successful merges: #40387, #40433, #40452, #40456, #40457, #40463, #40466, #40467, #40495, #40496, #40497, #40500, #40503, #40505, #40512, #40514, #40517, #40520
- Failed merges:
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40387 - tbu-:pr_doc_ptr_write2, r=steveklabnik
9bd88b1 
Reword the non-dropping of `src` for `ptr::write{,_unaligned}`

@niconii Is it OK if I put your wording into the documentation?
CC @nagisa
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40387 - tbu-:pr_doc_ptr_write2, r=steveklabnik
8f54ced 
Reword the non-dropping of `src` for `ptr::write{,_unaligned}`

@niconii Is it OK if I put your wording into the documentation?
CC @nagisa
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40387 - tbu-:pr_doc_ptr_write2, r=steveklabnik
a91ecdb 
Reword the non-dropping of `src` for `ptr::write{,_unaligned}`

@niconii Is it OK if I put your wording into the documentation?
CC @nagisa
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40387 - tbu-:pr_doc_ptr_write2, r=steveklabnik
8523680 
Reword the non-dropping of `src` for `ptr::write{,_unaligned}`

@niconii Is it OK if I put your wording into the documentation?
CC @nagisa
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40387 - tbu-:pr_doc_ptr_write2, r=steveklabnik
70e7327 
Reword the non-dropping of `src` for `ptr::write{,_unaligned}`

@niconii Is it OK if I put your wording into the documentation?
CC @nagisa
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Merged
bors added a commit that referenced this pull request Mar 17, 2017
@bors
Auto merge of #40598 - frewsxcv:rollup, r=frewsxcv
a559452 
Rollup of 23 pull requests

- Successful merges: #40387, #40433, #40452, #40456, #40457, #40458, #40463, #40466, #40467, #40495, #40496, #40497, #40499, #40500, #40503, #40505, #40512, #40514, #40517, #40520, #40536, #40545, #40586
- Failed merges:
@bors bors merged commit 13341f4 into rust-lang:master Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tbu- @rust-highfive @nagisa @niconii @steveklabnik @bors @brson