Remove function invokation parens from documentation links. #40456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
This PR was generated via: |
|
cc @rust-lang/docs |
|
I'm still sad about this. :'( @bors: r+ rollup |
|
📌 Commit eee5ec1 has been approved by |
ollie27
reviewed
Mar 13, 2017
src/libstd/thread/mod.rs
Outdated
| //! [`thread::park()`][`park()`] function and [`thread::Thread::unpark()`][`unpark()`] | ||
| //! method. [`park()`] blocks the current thread, which can then be resumed from | ||
| //! another thread by calling the [`unpark()`] method on the blocked thread's handle. | ||
| //! [`thread::park()`][`park`] function and [`thread::Thread::unpark()`][`unpark`] |
src/libstd/thread/mod.rs
Outdated
| //! | ||
| //! Conceptually, each [`Thread`] handle has an associated token, which is | ||
| //! initially not present: | ||
| //! | ||
| //! * The [`thread::park()`][`park()`] function blocks the current thread unless or until | ||
| //! * The [`thread::park()`][`park`] function blocks the current thread unless or until |
|
@bors: r- thanks @ollie27 me too @GuillaumeGomez |
This was never established as a convention we should follow in the 'More API Documentation Conventions' RFC: https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
frewsxcv
force-pushed
the
frewsxcv-docs-function-parens
branch
from
eee5ec1
to
e7b0f2b
Compare
|
Seems fixed now. @bors: r+ rollup |
|
📌 Commit e7b0f2b has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 14, 2017
…ens, r=GuillaumeGomez Remove function invokation parens from documentation links. This was never established as a convention we should follow in the 'More API Documentation Conventions' RFC: https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 15, 2017
…ens, r=GuillaumeGomez Remove function invokation parens from documentation links. This was never established as a convention we should follow in the 'More API Documentation Conventions' RFC: https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
bors
added a commit
that referenced
this pull request
Mar 15, 2017
bors
added a commit
that referenced
this pull request
Mar 16, 2017
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…ens, r=GuillaumeGomez Remove function invokation parens from documentation links. This was never established as a convention we should follow in the 'More API Documentation Conventions' RFC: https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…ens, r=GuillaumeGomez Remove function invokation parens from documentation links. This was never established as a convention we should follow in the 'More API Documentation Conventions' RFC: https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…ens, r=GuillaumeGomez Remove function invokation parens from documentation links. This was never established as a convention we should follow in the 'More API Documentation Conventions' RFC: https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…ens, r=GuillaumeGomez Remove function invokation parens from documentation links. This was never established as a convention we should follow in the 'More API Documentation Conventions' RFC: https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was never established as a convention we should follow in the 'More
API Documentation Conventions' RFC:
https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md