-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keep the AST node-id when lowering ExprKind::Range #40764
Conversation
When the Range expression is the root of a constant, its node-id is used for the def-id of the body, so it has to be preserved in the AST -> HIR lowering. Fixes rust-lang#40749.
@bors r+ |
📌 Commit 8ffe406 has been approved by |
Marking as beta-accepted. Small patch, regression. cc @rust-lang/compiler |
keep the AST node-id when lowering ExprKind::Range When the Range expression is the root of a constant, its node-id is used for the def-id of the body, so it has to be preserved in the AST -> HIR lowering. Fixes rust-lang#40749. r? @eddyb beta-nominating because regression
⌛ Testing commit 8ffe406 with merge 4e9953d... |
💔 Test failed - status-travis |
⌛ Testing commit 8ffe406 with merge 3e8c572... |
💔 Test failed - status-travis |
☀️ Test successful - status-appveyor, status-travis |
@arielb1 unfortunately this doesn't apply cleanly to the beta branch, would you mind looking into the backport? |
[beta] Beta next - rust-lang#40764 - rust-lang#40809 - rust-lang#41015 r? @brson
When the Range expression is the root of a constant, its node-id is
used for the def-id of the body, so it has to be preserved in the AST ->
HIR lowering.
Fixes #40749.
r? @eddyb
beta-nominating because regression