Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep the AST node-id when lowering ExprKind::Range #40764

Merged
merged 1 commit into from
Mar 27, 2017

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Mar 23, 2017

When the Range expression is the root of a constant, its node-id is
used for the def-id of the body, so it has to be preserved in the AST ->
HIR lowering.

Fixes #40749.

r? @eddyb
beta-nominating because regression

When the Range expression is the root of a constant, its node-id is
used for the def-id of the body, so it has to be preserved in the AST ->
HIR lowering.

Fixes rust-lang#40749.
@arielb1 arielb1 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 23, 2017
@eddyb
Copy link
Member

eddyb commented Mar 23, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Mar 23, 2017

📌 Commit 8ffe406 has been approved by eddyb

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 23, 2017
@nikomatsakis
Copy link
Contributor

Marking as beta-accepted. Small patch, regression.

cc @rust-lang/compiler

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 25, 2017
keep the AST node-id when lowering ExprKind::Range

When the Range expression is the root of a constant, its node-id is
used for the def-id of the body, so it has to be preserved in the AST ->
HIR lowering.

Fixes rust-lang#40749.

r? @eddyb
beta-nominating because regression
bors added a commit that referenced this pull request Mar 25, 2017
Rollup of 11 pull requests

- Successful merges: #40347, #40501, #40516, #40524, #40540, #40642, #40683, #40764, #40778, #40807, #40809
- Failed merges: #40771
bors added a commit that referenced this pull request Mar 25, 2017
Rollup of 11 pull requests

- Successful merges: #40347, #40501, #40516, #40524, #40540, #40642, #40683, #40764, #40778, #40807, #40809
- Failed merges: #40771
@bors
Copy link
Contributor

bors commented Mar 25, 2017

⌛ Testing commit 8ffe406 with merge 4e9953d...

@bors
Copy link
Contributor

bors commented Mar 25, 2017

💔 Test failed - status-travis

@arielb1
Copy link
Contributor Author

arielb1 commented Mar 25, 2017

@bors
Copy link
Contributor

bors commented Mar 25, 2017

⌛ Testing commit 8ffe406 with merge 3e8c572...

@bors
Copy link
Contributor

bors commented Mar 25, 2017

💔 Test failed - status-travis

@arielb1
Copy link
Contributor Author

arielb1 commented Mar 25, 2017

@bors
Copy link
Contributor

bors commented Mar 27, 2017

⌛ Testing commit 8ffe406 with merge ccce2c6...

bors added a commit that referenced this pull request Mar 27, 2017
keep the AST node-id when lowering ExprKind::Range

When the Range expression is the root of a constant, its node-id is
used for the def-id of the body, so it has to be preserved in the AST ->
HIR lowering.

Fixes #40749.

r? @eddyb
beta-nominating because regression
@bors
Copy link
Contributor

bors commented Mar 27, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing ccce2c6 to master...

@bors bors merged commit 8ffe406 into rust-lang:master Mar 27, 2017
@alexcrichton
Copy link
Member

@arielb1 unfortunately this doesn't apply cleanly to the beta branch, would you mind looking into the backport?

@arielb1 arielb1 mentioned this pull request Apr 2, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 3, 2017
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants