-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump mdbook dep to pick up new 'create missing' toggle feature. #41572
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Hold off on r+'ing this, I want to confirm this is working as intended. |
Blocked on https://github.com/azerupi/mdBook/pull/259. |
@frewsxcv looks like that was merged and published |
This will avoid obscure Travis CI error messages: * rust-lang#40290 (comment) Original mdbook issue: * https://github.com/azerupi/mdBook/issues/253 mdbook PR: * https://github.com/azerupi/mdBook/pull/254
cool, everything is working.
@steveklabnik this is ready for review now |
Looks like the build was cancelled on Travis, but this should be still good to go. |
This looks good; I've restarted the build. r=me once travis passes. |
@bors r=steveklabnik |
📌 Commit a517a96 has been approved by |
Bump mdbook dep to pick up new 'create missing' toggle feature. This will avoid obscure Travis CI error messages: * rust-lang#40290 (comment) Original mdbook issue: * https://github.com/azerupi/mdBook/issues/253 mdbook PR: * https://github.com/azerupi/mdBook/pull/254
This will avoid obscure Travis CI error messages:
as_bytes()
forFromUtf8Error
. #40290 (comment)Original mdbook issue:
mdbook PR: