typeck: resolve type vars before calling try_index_step
#41578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`try_index_step` does not resolve type variables by itself and would fail otherwise. Also harden the failure path in `confirm` to cause less confusing errors.
arielb1
added
the
beta-nominated
eddyb
approved these changes
Apr 27, 2017
|
@bors r+ |
|
📌 Commit a260df2 has been approved by |
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Apr 27, 2017
typeck: resolve type vars before calling `try_index_step` `try_index_step` does not resolve type variables by itself and would fail otherwise. Also harden the failure path in `confirm` to cause less confusing errors. r? @eddyb Fixes rust-lang#41498. beta-nominating because regression (caused by rust-lang#41279).
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 27, 2017
typeck: resolve type vars before calling `try_index_step` `try_index_step` does not resolve type variables by itself and would fail otherwise. Also harden the failure path in `confirm` to cause less confusing errors. r? @eddyb Fixes rust-lang#41498. beta-nominating because regression (caused by rust-lang#41279).
alexcrichton
added
the
S-waiting-on-bors
nikomatsakis
added
the
beta-accepted
|
Accepted for beta. Relatively small, regression. |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 27, 2017
typeck: resolve type vars before calling `try_index_step` `try_index_step` does not resolve type variables by itself and would fail otherwise. Also harden the failure path in `confirm` to cause less confusing errors. r? @eddyb Fixes rust-lang#41498. beta-nominating because regression (caused by rust-lang#41279).
bors
added a commit
that referenced
this pull request
Apr 28, 2017
Merged
alexcrichton
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
May 11, 2017
[beta] backports - #41666 - #41578 - #41548 - #41529 r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try_index_stepdoes not resolve type variables by itself and wouldfail otherwise. Also harden the failure path in
confirmto cause lessconfusing errors.
r? @eddyb
Fixes #41498.
beta-nominating because regression (caused by #41279).