Try fixing bigendian metadata serialisation #41666
Conversation
I compiled this on PPC to check and it seems to work, but not sure whether I didn't mess up anything in a major way. Maybe a good shot at rust-lang#41443
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 54de274 has been approved by |
Try fixing bigendian metadata serialisation I compiled this on PPC to check and it seems to work, but not sure whether I didn't mess up anything in a major way. Maybe a good shot at #41443 The easiest way to *really* test this is to land the patch (a high priority would be good, since I quite literally am just twiddling my thumbs on this now), wait for nightly, and, if the nightly works, backport this to beta.
arielb1
added
A-associated-items
|
☀️ Test successful - status-appveyor, status-travis |
|
🎉 |
|
Confirming the relevant issue as fixed. |
|
Are you backporting this to beta? I guess we need someone to agree on |
nagisa
added
the
T-compiler
|
We’ll discuss accepting this for backport on Thursday’s compiler team meeting. |
|
I'd be in favor of backporting; small patch. I've not looked deeply at the other side to confirm it's correct, but since nothing has fallen over, and it was tested, I'm assuming it is. =) cc @rust-lang/compiler |
nikomatsakis
added
the
beta-accepted
|
I went ahead and marked as accepted since today is a "focus" mtg. If anyone objects, feel free to leave a comment! |
|
+1 for backporting |
alexcrichton
removed
the
beta-nominated
[beta] backports - #41666 - #41578 - #41548 - #41529 r? @alexcrichton
I compiled this on PPC to check and it seems to work, but not sure whether I didn't mess up
anything in a major way.
Maybe a good shot at #41443
The easiest way to really test this is to land the patch (a high priority would be good, since I quite literally am just twiddling my thumbs on this now), wait for nightly, and, if the nightly works, backport this to beta.