-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow ._ in float literal. #41946
Disallow ._ in float literal. #41946
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks for the pull request! We'll get @pnkfelix or another team member to review this shortly! |
@bors r+ rollup |
📌 Commit 7b535e1 has been approved by |
…loat, r=petrochenkov Disallow ._ in float literal. This patch makes lexer stop parsing number literals before `._`, as well as before `.a`. Underscore itself is still allowed like in `4_000_000.000_000_`. Fixes a half part of rust-lang#41723. The other is `""_`.
…loat, r=petrochenkov Disallow ._ in float literal. This patch makes lexer stop parsing number literals before `._`, as well as before `.a`. Underscore itself is still allowed like in `4_000_000.000_000_`. Fixes a half part of rust-lang#41723. The other is `""_`.
…loat, r=petrochenkov Disallow ._ in float literal. This patch makes lexer stop parsing number literals before `._`, as well as before `.a`. Underscore itself is still allowed like in `4_000_000.000_000_`. Fixes a half part of rust-lang#41723. The other is `""_`.
This patch makes lexer stop parsing number literals before
._
, as well as before.a
. Underscore itself is still allowed like in4_000_000.000_000_
.Fixes a half part of #41723. The other is
""_
.