Rollup of 5 pull requests

[frewsxcv]

• Successful merges: Add markdown-[before|after]-content options #41826, Include the crate's root module in save-analysis #41919, Disallow ._ in float literal. #41946, Reenable opt-level 3 #41967, Update RLS to solve serious crash #41969
• Failed merges: rustc_resolve: don't deny outer type parameters in embedded constants. #41939

[frewsxcv]

@bors r+ p=10

[bors]

📌 Commit 9d65556 has been approved by frewsxcv

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[bors]

⌛ Testing commit 9d65556 with merge 4d29d84...

[bors]

💔 Test failed - status-appveyor

[Mark-Simulacrum]

Spurious? I think? No errors... Odd.

@bors retry force

[00:21:11]    Compiling syntax_pos v0.0.0 (file:///C:/projects/rust/src/libsyntax_pos)
[00:21:14]    Compiling rustc_errors v0.0.0 (file:///C:/projects/rust/src/librustc_errors)
[00:21:19]    Compiling rustc_data_structures v0.0.0 (file:///C:/projects/rust/src/librustc_data_structures)
[00:21:22]    Compiling rustc-serialize v0.3.23
[00:21:31]    Compiling syntax v0.0.0 (file:///C:/projects/rust/src/libsyntax)
[00:21:32]    Compiling rls-span v0.4.0
[00:21:33]    Compiling rls-data v0.3.1
[00:24:54]    Compiling proc_macro v0.0.0 (file:///C:/projects/rust/src/libproc_macro)
[00:24:54]    Compiling rustc_const_math v0.0.0 (file:///C:/projects/rust/src/librustc_const_math)
[00:24:56]    Compiling rustc_back v0.0.0 (file:///C:/projects/rust/src/librustc_back)
[00:24:56]    Compiling syntax_ext v0.0.0 (file:///C:/projects/rust/src/libsyntax_ext)
[00:25:17]    Compiling rustc v0.0.0 (file:///C:/projects/rust/src/librustc)
[00:29:19] error: Could not compile `rustc`.
[00:29:19]
[00:29:19] To learn more, run the command again with --verbose.
[00:29:19]
[00:29:19]
[00:29:19] command did not execute successfully: "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage0/bin\\cargo.exe" "build" "-j" "2" "--target" "x86_64-pc-windows-msvc" "--release" "--locked" "--features" "" "--manifest-path" "C:\\projects\\rust\\src/rustc/Cargo.toml"
[00:29:19] expected success, got: exit code: 101

[Mark-Simulacrum]

@bors retry

I have no clue how this syntax really works...

[bors]

⌛ Testing commit 9d65556 with merge 2a03443...

[frewsxcv]

@Mark-Simulacrum probably #41967 ?

[Mark-Simulacrum]

Maybe, but that looks like it is only MSVC related.

[Mark-Simulacrum]

@bors r- (since @alexcrichton r- a PR this contains)

[Mark-Simulacrum]

@bors retry