Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused APIs from rustc_trans #42266

Merged
merged 2 commits into from
May 28, 2017
Merged

Conversation

hanna-kruppe
Copy link
Contributor

There were public re-exports of some rustc modules dating back to 2011 or so. While I was at it, some functions and modules were public but never used outside the crate. I made them private or pub(crate) as appropriate and in one case removed an unused function.

Robin Kruppe added 2 commits May 27, 2017 21:08
Mark various items and fields as private or pub(crate), and remove a function that turns out to be unused.
These are not used anywhere in-tree, but I guess it's a [breaking-change] for plugins.
The previous commit removed them from the public API, this rewrites the use statements to get rid of the non-standard re-exports.
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1
Copy link
Contributor

arielb1 commented May 27, 2017

@bors r+

@bors
Copy link
Contributor

bors commented May 27, 2017

📌 Commit 6fec17e has been approved by arielb1

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 28, 2017
Remove unused APIs from rustc_trans

There were public re-exports of some rustc modules dating back to 2011 or so. While I was at it, some functions and modules were public but never used outside the crate. I made them private or `pub(crate)` as appropriate and in one case removed an unused function.
@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 28, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 28, 2017
Remove unused APIs from rustc_trans

There were public re-exports of some rustc modules dating back to 2011 or so. While I was at it, some functions and modules were public but never used outside the crate. I made them private or `pub(crate)` as appropriate and in one case removed an unused function.
bors added a commit that referenced this pull request May 28, 2017
Rollup of 6 pull requests

- Successful merges: #42207, #42217, #42249, #42251, #42260, #42266
- Failed merges:
@bors bors merged commit 6fec17e into rust-lang:master May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants