Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spans for binary operator expression with interpolated identifiers #43053

Closed
wants to merge 1 commit into from
Closed

Fix spans for binary operator expression with interpolated identifiers #43053

wants to merge 1 commit into from

Conversation

petrochenkov
Copy link
Contributor

Fixes #42954

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov
Copy link
Contributor Author

r? @estebank

@petrochenkov petrochenkov mentioned this pull request Jul 4, 2017
Merged
@estebank
Copy link
Contributor

estebank commented Jul 5, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Jul 5, 2017

📌 Commit a0036cb has been approved by estebank

@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 5, 2017
@bors
Copy link
Contributor

bors commented Jul 6, 2017

🔒 Merge conflict

@alexcrichton alexcrichton added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2017
@petrochenkov
Copy link
Contributor Author

I'll close this in favor of #43060 containing the same commit.

@petrochenkov petrochenkov deleted the binopspan branch August 26, 2017 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@petrochenkov @rust-highfive @estebank @bors @alexcrichton @nikomatsakis @aidanhs