syntax: Apply x as usize < y recovery to type ascription as well
#43060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanhs
added
the
S-waiting-on-review
estebank
reviewed
Jul 5, 2017
src/test/ui/issue-22644.stderr
Outdated
| | ^--------------------- | ||
| | | | ||
| | interpreted as generic arguments | ||
| | not interpreted as comparison |
There was a problem hiding this comment.
Will look at the code this afternoon to see what change would be needed for this suggestion to be implemented, but I feel the output should be:
|
20 | println!("{}{}", a: usize < long_name, long_name);
| ^ -------------------- interpreted as generic arguments
| |
| not interpreted as comparison
|
@estebank |
|
@bors r+ |
|
📌 Commit 0e10bd8 has been approved by |
|
☔ The latest upstream changes (presumably #42904) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Rebased. |
|
📌 Commit 4323877 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 7, 2017
syntax: Apply `x as usize < y` recovery to type ascription as well Also correct spans, add some comments. r? @estebank
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also correct spans, add some comments.
r? @estebank