Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test MIR validation statements in closures #43650

Merged
merged 2 commits into from
Aug 11, 2017
Merged

test MIR validation statements in closures #43650

merged 2 commits into from
Aug 11, 2017

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 5, 2017

@arielb1
Copy link
Contributor

arielb1 commented Aug 8, 2017

r? @arielb1

@arielb1 arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2017
@arielb1 arielb1 assigned arielb1 and unassigned nikomatsakis Aug 8, 2017
arielb1
arielb1 reviewed Aug 8, 2017
View reviewed changes
src/test/mir-opt/validate_5.rs
// StorageDead(_5);
// EndRegion(ReScope(Misc(NodeId(44))));
// Validate(Release, [_0: bool, _4: *mut i32]);
// _0 = const write_42(_4) -> bb1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like UB. If that is intentional, please add a comment.

@arielb1
Copy link
Contributor

arielb1 commented Aug 8, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Aug 8, 2017

📌 Commit 21a707e has been approved by arielb1

@arielb1
Copy link
Contributor

arielb1 commented Aug 8, 2017

@bors rollup

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 11, 2017
@GuillaumeGomez
Rollup merge of rust-lang#43650 - RalfJung:mir-validate, r=arielb1
96c09f8 
test MIR validation statements in closures

r? @nikomatsakis
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 11, 2017
Merged
bors added a commit that referenced this pull request Aug 11, 2017
@bors
Auto merge of #43800 - GuillaumeGomez:rollup, r=GuillaumeGomez
59675d2 
Rollup of 18 pull requests

- Successful merges: #43176, #43632, #43650, #43712, #43715, #43721, #43739, #43741, #43744, #43747, #43752, #43760, #43773, #43779, #43783, #43791, #43793, #43795
- Failed merges:
MaloJaffre added a commit to MaloJaffre/rust that referenced this pull request Aug 11, 2017
@MaloJaffre
Rollup merge of rust-lang#43650 - RalfJung:mir-validate, r=arielb1
9dba107 
test MIR validation statements in closures

r? @nikomatsakis
@MaloJaffre MaloJaffre mentioned this pull request Aug 11, 2017
Closed
@bors bors merged commit 21a707e into rust-lang:master Aug 11, 2017
@RalfJung RalfJung deleted the mir-validate branch July 10, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielb1 arielb1 arielb1 left review comments

Assignees

@arielb1 arielb1

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RalfJung @arielb1 @bors @nikomatsakis