Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IRC's !union union as a test, addresses #43553 #43752

Merged
merged 1 commit into from
Aug 11, 2017
Merged

Add IRC's !union union as a test, addresses #43553 #43752

merged 1 commit into from
Aug 11, 2017

Conversation

arshiamufti
Copy link
Contributor

This pull request adds a new test, union to weird-exprs.rs.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sfackler
Copy link
Member

sfackler commented Aug 9, 2017

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 9, 2017

📌 Commit 0f924b8 has been approved by sfackler

@kennytm
Copy link
Member

kennytm commented Aug 9, 2017

cc #43553 (titles won't make a link).

@bors
Copy link
Contributor

bors commented Aug 9, 2017

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Aug 9, 2017

📌 Commit 0f924b8 has been approved by estebank

@bors
Copy link
Contributor

bors commented Aug 9, 2017

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Aug 9, 2017

📌 Commit 0f924b8 has been approved by estebank

@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 10, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 11, 2017
@GuillaumeGomez
Rollup merge of rust-lang#43752 - arshiamufti:union-test, r=estebank
35947cf 
Add IRC's `!union union` as a test, addresses rust-lang#43553

This pull request adds a new test, `union` to `weird-exprs.rs`.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 11, 2017
Merged
bors added a commit that referenced this pull request Aug 11, 2017
@bors
Auto merge of #43800 - GuillaumeGomez:rollup, r=GuillaumeGomez
59675d2 
Rollup of 18 pull requests

- Successful merges: #43176, #43632, #43650, #43712, #43715, #43721, #43739, #43741, #43744, #43747, #43752, #43760, #43773, #43779, #43783, #43791, #43793, #43795
- Failed merges:
MaloJaffre added a commit to MaloJaffre/rust that referenced this pull request Aug 11, 2017
@MaloJaffre
Rollup merge of rust-lang#43752 - arshiamufti:union-test, r=estebank
0ea8e0e 
Add IRC's `!union union` as a test, addresses rust-lang#43553

This pull request adds a new test, `union` to `weird-exprs.rs`.
@MaloJaffre MaloJaffre mentioned this pull request Aug 11, 2017
Closed
@bors bors merged commit 0f924b8 into rust-lang:master Aug 11, 2017
@tamird tamird mentioned this pull request Aug 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@arshiamufti @rust-highfive @sfackler @bors @kennytm @nikomatsakis @aidanhs