Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #44678

Merged
merged 34 commits into from
Sep 18, 2017
Merged

Rollup of 11 pull requests #44678

merged 34 commits into from
Sep 18, 2017

Commits on Sep 10, 2017

  1. Configuration menu
    Copy the full SHA
    778d5f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2017

  1. Add proper help line for inline threshold

    Also remove a period on a different help line for consistency
    oyvindln committed Sep 13, 2017
    Configuration menu
    Copy the full SHA
    edf1622 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e89748e View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2017

  1. std: Document thread builder panics for nul bytes in thread names

    This seems to have been undocumented. Mention this where the name is set
    (Builder::name) and where the panic could happen (Builder::spawn).
    
    Thread::new is private and I think the builder is the only user where
    this matters. A short comment was added to "document" Thread::new too.
    bluss committed Sep 17, 2017
    Configuration menu
    Copy the full SHA
    7859c9e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7b932d2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6b167f9 View commit details
    Browse the repository at this point in the history
  4. Replace str's transmute() calls with pointer casts

    After the following conversation in #rust-lang:
    ```
    [14:43:50] <Ixrec> TIL the implementation of from_utf_unchecked is literally just "mem::transmute(x)"
    [14:43:59] <Ixrec> no wonder people keep saying transmute is overpowered
    [15:15:30] <eddyb> Ixrec: it should be a pointer cast lol
    [15:15:46] <eddyb> unless it doesn't let you
    [16:50:34] <Ixrec> https://play.rust-lang.org/?gist=d1e6b629ad9ec1baf64ce261c63845e6&version=stable seems like it does let me
    [16:52:35] <eddyb> Ixrec: yeah that's the preferred impl
    [16:52:46] <eddyb> Ixrec: it just wasn't in 1.0
    [16:52:50] <eddyb> IIRC
    [16:53:00] <eddyb> (something something fat pointers)
    ```
    Since I already wrote half of the preferred impls in the playground, might as well make an actual PR.
    Ixrec authored Sep 17, 2017
    Configuration menu
    Copy the full SHA
    2633b85 View commit details
    Browse the repository at this point in the history
  5. missed a 'mut'

    Ixrec authored Sep 17, 2017
    Configuration menu
    Copy the full SHA
    38fa340 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2787a28 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e47279f View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2017

  1. Configuration menu
    Copy the full SHA
    ebd0e4f View commit details
    Browse the repository at this point in the history
  2. Use DefId instead of NodeId as identifier in resolve_lifetime::Region.

    These Region values end up in crate metadata so they should not use NodeId.
    michaelwoerister committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    3cf28f3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e6c9a53 View commit details
    Browse the repository at this point in the history
  4. incr.comp.: Move result fingerprinting to DepGraph::with_task().

    This makes sure that we don't introduce strange cases where we have
    nodes outside the query system that could break red/green tracking
    and it will allow to keep red/green neatly encapsulated within the
    DepGraph implementation.
    michaelwoerister committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    3cc3ae2 View commit details
    Browse the repository at this point in the history
  5. Fix issues uncovered by rebasing:

    - Don't hash traits in scope as part of HIR hashing any more.
    - Some queries returned DefIndexes from other crates.
    - Provide a generic way of stably hashing maps (not used everywhere yet).
    michaelwoerister committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    e3f9131 View commit details
    Browse the repository at this point in the history
  6. incr.comp.: Already hash HIR bodies during metadata export so they do…

    …n't have to be hashed in downstream crates.
    michaelwoerister committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    b9816c5 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    67c84e0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    dd50173 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e567afb View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ba6f93c View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d5b1fee View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    74d6b85 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    4961a8e View commit details
    Browse the repository at this point in the history
  14. Fix run button

    GuillaumeGomez committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    90ce24a View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#44364 - michaelwoerister:hash-all-the-thing…

    …s2, r=nikomatsakis
    
    incr.comp.: Compute fingerprint for all query results.
    
    This PR enables query result fingerprinting in incremental mode. This is an essential piece of infrastructure for red/green tracking. We don't do anything with the fingerprints yet but merging the infrastructure should protect it from bit-rotting and will make it easier to start measuring its performance impact (and thus let us determine if we should switch to a faster hashing algorithm rather sooner than later).
    
    Note, this PR also includes the changes from rust-lang#43887 which I'm therefore closing. No need to re-review the first commit though.
    
    r? @nikomatsakis
    alexcrichton authored Sep 18, 2017
    Configuration menu
    Copy the full SHA
    9ad5473 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#44466 - clarcharr:cow_error, r=alexcrichton

    Add Cow<str> -> Box<Error> impls.
    
    Considering how impls exist for `String` and `&str`, it makes sense to also add an impl for `Cow<str>` as well.
    
    This would allow converting `String::from_utf8_lossy` directly into a `Box<Error>` or `io::Error` without having to add an extra `into_ownd()`.
    alexcrichton authored Sep 18, 2017
    Configuration menu
    Copy the full SHA
    fbf3b8a View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#44537 - oli-obk:memchr, r=alexcrichton

    More `align_offset` things
    
    cc rust-lang#44488
    alexcrichton authored Sep 18, 2017
    Configuration menu
    Copy the full SHA
    8dae2b0 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#44548 - oyvindln:rustc_help_fix, r=arielb1

    Add proper help line for `-C inline threshold`
    
    Looks like someone accidentally some words when adding this.
    
    This also remove a period on a different help line for consistency, as no options have a period.
    alexcrichton authored Sep 18, 2017
    Configuration menu
    Copy the full SHA
    156698e View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#44640 - budziq:stabilize_splice, r=dtolnay

    Stabilized vec_splice and modified splice tracking issue
    
    This stabilizes the vec_splice (Vec part of splice RFC)
    Fixes rust-lang#32310.
    alexcrichton authored Sep 18, 2017
    Configuration menu
    Copy the full SHA
    fa9dd27 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#44651 - bluss:document-thread-name-no-nuls,…

    … r=steveklabnik
    
    Document thread builder panics for nul bytes in thread names
    
    This seems to have been undocumented. Mention this where the name is set
    (Builder::name) and where the panic could happen (Builder::spawn).
    
    Thread::new is private and I think the builder is the only user where
    this matters. A short comment was added to "document" Thread::new too.
    alexcrichton authored Sep 18, 2017
    Configuration menu
    Copy the full SHA
    d5b0cbb View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#44657 - Ixrec:patch-1, r=eddyb

    Replace str's transmute() calls with pointer casts
    
    After the following conversation in #rust-lang:
    ```
    [14:43:50] <Ixrec> TIL the implementation of from_utf_unchecked is literally just "mem::transmute(x)"
    [14:43:59] <Ixrec> no wonder people keep saying transmute is overpowered
    [15:15:30] <eddyb> Ixrec: it should be a pointer cast lol
    [15:15:46] <eddyb> unless it doesn't let you
    [16:50:34] <Ixrec> https://play.rust-lang.org/?gist=d1e6b629ad9ec1baf64ce261c63845e6&version=stable seems like it does let me
    [16:52:35] <eddyb> Ixrec: yeah that's the preferred impl
    [16:52:46] <eddyb> Ixrec: it just wasn't in 1.0
    [16:52:50] <eddyb> IIRC
    [16:53:00] <eddyb> (something something fat pointers)
    ```
    Since I already wrote half of the preferred impls in the playground, might as well make an actual PR.
    alexcrichton authored Sep 18, 2017
    Configuration menu
    Copy the full SHA
    64c9fd6 View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#44661 - GuillaumeGomez:more-links, r=QuietM…

    …isdreavus
    
    Add more links and put the link character to the left
    
    r? @QuietMisdreavus
    
    And of course, a few screenshots:
    
    <img width="1440" alt="screen shot 2017-09-17 at 22 08 46" src="https://user-images.githubusercontent.com/3050060/30524496-44a50208-9bf5-11e7-942e-a3707ba125c3.png">
    <img width="1440" alt="screen shot 2017-09-17 at 22 09 47" src="https://user-images.githubusercontent.com/3050060/30524502-49068dbc-9bf5-11e7-8e59-ec38664e0e0f.png">
    <img width="1440" alt="screen shot 2017-09-17 at 22 10 56" src="https://user-images.githubusercontent.com/3050060/30524503-491c8c34-9bf5-11e7-9ce5-f1bd5ef8600b.png">
    alexcrichton authored Sep 18, 2017
    Configuration menu
    Copy the full SHA
    3bbe153 View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#44668 - iwillspeak:into-iterator-docs, r=st…

    …eveklabnik
    
    Add Example of `IntoIterator` as Trait Bound to Docs
    
    Part of rust-lang#44600.
    alexcrichton authored Sep 18, 2017
    Configuration menu
    Copy the full SHA
    4af3073 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    929215d View commit details
    Browse the repository at this point in the history