[WIP] Generic Associated Types Name Resolution #46146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunjay
commented
Nov 21, 2017
src/librustc_resolve/lib.rs
Outdated
| @@ -1895,7 +1895,9 @@ impl<'a> Resolver<'a> { | |||
| }); | |||
| } | |||
| TraitItemKind::Type(..) => { | |||
| this.with_type_parameter_rib(NoTypeParameters, |this| { | |||
| let type_parameters = HasTypeParameters(&trait_item.generics, | |||
| ItemRibKind); | |||
There was a problem hiding this comment.
Is ItemRibKind the right RibKind?
src/librustc_resolve/lib.rs
Outdated
| // We also need a new scope for the associated type | ||
| // specific type parameters. | ||
| let type_parameters = | ||
| HasTypeParameters(&impl_item.generics, ItemRibKind); |
There was a problem hiding this comment.
Is ItemRibKind the right RibKind? Is this the right way to visit these types? I copied what was done for methods a few lines above this.
kennytm
added
the
S-waiting-on-author
|
☔ The latest upstream changes (presumably #45771) made this pull request unmergeable. Please resolve the merge conflicts. |
…ld which was never used. Lifting the HasTypeParameters rib to all trait item kinds and all impl item kinds
3 tasks
|
This has been completed and merged into the other PR I had open for parsing (#45904). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off of the to-be-merged PR for parsing generic associated types. In fact, the only new commit is the latest one which makes changes to
src/librustc_resolve/lib.rs. You should look only at that file when reviewing this PR. Once the other PR is merged and this PR is rebased, the remaining files will disappear.This PR is a work in progress and only meant to give me a way to show @nikomatsakis my progress and ask questions. I am still waiting for the build to finish locally on my computer and then I will update this PR as I find and fix errors.
Tracking Issue: #44265
r? @nikomatsakis
Notes & Questions for Reviewers
Something to check: Am I using the right
RibKindvariants? I don't actually fully understand the differences from the docs in the code so it's quite possible that I didn't choose the right one.From the instructions by @nikomatsakis on the Tracking Issue:
I had to modify this a bit because I chose different
RibKinds for Methods and Types. If it turns out theRibKindshould be the same in all cases, I can lift out that call towith_type_parameter_riband add theHasTypeParametersrib only once.By the end of this, the run-pass tests should actually pass! 🎉
It's possible that I still need to add more tests before this should be merged