Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Generic Associated Types Name Resolution #46146

Closed
wants to merge 12 commits into from
Closed

[WIP] Generic Associated Types Name Resolution #46146

wants to merge 12 commits into from

Commits on Nov 21, 2017

  1. Parsing generics in both trait items and impl items

    @sunjay
    sunjay committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    aa868af View commit details
    Browse the repository at this point in the history

  2. Added run-pass tests for associated generic types

    @sunjay
    sunjay committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    789aaa0 View commit details
    Browse the repository at this point in the history

  3. Adding feature gate

    @sunjay
    sunjay committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    4e00e0a View commit details
    Browse the repository at this point in the history

  4. Fixed tidy errors

    @sunjay
    sunjay committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    ca454e8 View commit details
    Browse the repository at this point in the history

  5. More testing for generic associated types parsing

    @sunjay
    sunjay committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    db3ecd9 View commit details
    Browse the repository at this point in the history

  6. Added stderr files for ui tests

    @sunjay
    sunjay committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    5691b31 View commit details
    Browse the repository at this point in the history

  7. demonstrate how we can write "successful parse" tests quite easily

    @nikomatsakis @sunjay
    nikomatsakis authored and sunjay committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    493e813 View commit details
    Browse the repository at this point in the history

  8. Specifically gating generic_associated_types feature on associated Ty… 

    …pe declarations
    @sunjay
    sunjay committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    d480a75 View commit details
    Browse the repository at this point in the history

  9. Parsing where clauses correctly and documenting the grammar being parsed

    @sunjay
    sunjay committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    b012495 View commit details
    Browse the repository at this point in the history

  10. Preventing moving out of the trait item kind

    @sunjay
    sunjay committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    28fd354 View commit details
    Browse the repository at this point in the history

  11. Adding type paramter ribs for generic associated types

    @sunjay
    sunjay committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    d43e972 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2017

  1. Renaming MethodRibKind to TraitOrImplItemRibKind and removing its fie… 

    …ld which was never used. Lifting the HasTypeParameters rib to all trait item kinds and all impl item kinds
    @sunjay
    sunjay committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    d9879bf View commit details
    Browse the repository at this point in the history