Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point at def span on redefined name diagnostic #46802

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Point at def span on redefined name diagnostic #46802

merged 1 commit into from
Dec 19, 2017

Conversation

estebank
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@michaelwoerister
Copy link
Member

Seems like a clear improvement to me. Thanks, @estebank!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 18, 2017

📌 Commit 61181ae has been approved by michaelwoerister

@bors
Copy link
Contributor

bors commented Dec 18, 2017

⌛ Testing commit 61181ae with merge e2914c2e7c461c195ca4df510224180b586a590d...

@bors
Copy link
Contributor

bors commented Dec 18, 2017

💔 Test failed - status-travis

@estebank
Copy link
Contributor Author

@bors retry

@estebank
Copy link
Contributor Author

@bors r-

@estebank
Copy link
Contributor Author

@bors r=michaelwoerister

@bors
Copy link
Contributor

bors commented Dec 18, 2017

📌 Commit 61181ae has been approved by michaelwoerister

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 18, 2017
@estebank
Copy link
Contributor Author

@bors rollup

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 18, 2017
@GuillaumeGomez
Rollup merge of rust-lang#46802 - estebank:redefined-def-span, r=mich…
015502c 
…aelwoerister

Point at def span on redefined name diagnostic
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 18, 2017
Merged
bors added a commit that referenced this pull request Dec 19, 2017
@bors
Auto merge of #46829 - GuillaumeGomez:rollup, r=GuillaumeGomez
c8b94c6 
Rollup of 11 pull requests

- Successful merges: #46700, #46786, #46790, #46800, #46801, #46802, #46804, #46805, #46812, #46824, #46825
- Failed merges:
@bors bors merged commit 61181ae into rust-lang:master Dec 19, 2017
@arielb1 arielb1 mentioned this pull request Dec 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@estebank @rust-highfive @michaelwoerister @bors @kennytm