-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #46829
Merged
Merged
Rollup of 11 pull requests #46829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
Dec 18, 2017
- Successful merges: make doc search more relevant #46700, Fix ?Sized where bound not being displayed at the correct place #46786, Display binary notation for numeric swap_bytes methods. #46790, Rework expected closure error #46800, Point at def span in "impl has stricter requirements" diagnostic #46801, Point at def span on redefined name diagnostic #46802, Use def span for conflicting impls and recursive fn #46804, Tweak "unecessary unsafe block" error spans #46805, Fix the wrong subtraction in align_offset intrinsic. #46812, Fix dynamic crates listing in doc sidebar #46824, Improve search display on mobile #46825
- Failed merges:
This better illustrates what's happening to the bits behind the scenes.
* point at def span * add label to primary span * use `span_label`s instead of `span_note`s
…arch, r=QuietMisdreavus make doc search more relevant Fixes rust-lang#46595. r? @QuietMisdreavus If possible, I'd appreciate a strong check on this PR. :3
… r=QuietMisdreavus Fix ?Sized where bound not being displayed at the correct place Fixes rust-lang#46726. r? @QuietMisdreavus
…etMisdreavus Display binary notation for numeric swap_bytes methods. This better illustrates what's happening to the bits behind the scenes.
… r=arielb1 Rework expected closure error * point at def span * add label to primary span * use `span_label`s instead of `span_note`s
…=arielb1 Point at def span in "impl has stricter requirements" diagnostic
…aelwoerister Point at def span on redefined name diagnostic
… r=arielb1 Use def span for conflicting impls and recursive fn
…r=arielb1 Tweak "unecessary unsafe block" error spans
…trochenkov Fix the wrong subtraction in align_offset intrinsic. Given how the stage0 implementation in rust-lang#43903 is written, as well as that in the RFC, I suppose the current implementation has a typo. cc rust-lang#44488, cc @oli-obk.
…Misdreavus Fix dynamic crates listing in doc sidebar Fixes rust-lang#46687. r? @QuietMisdreavus
…etMisdreavus Improve search display on mobile r? @QuietMisdreavus
Some changes occurred in HTML/CSS. |
r? @frewsxcv (rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ p=1 |
📌 Commit b5f6884 has been approved by |
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.