use correct casing for rename suggestions #47838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the original name is uppercase, use camel case. Otherwise, use snake case.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Nice. |
|
📌 Commit 043d461 has been approved by |
petrochenkov
added
the
S-waiting-on-bors
|
⌛ Testing commit 043d461 with merge 16c3ff6066a7b52e232b1fc49d33a1b1b3e8cf3d... |
|
💔 Test failed - status-appveyor |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 31, 2018
…ochenkov use correct casing for rename suggestions If the original name is uppercase, use camel case. Otherwise, use snake case.
bors
added a commit
that referenced
this pull request
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the original name is uppercase, use camel case. Otherwise, use snake
case.