Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_trans: keep LLVM types for trait objects anonymous. #47891

Merged
merged 1 commit into from
Jan 31, 2018
Merged

rustc_trans: keep LLVM types for trait objects anonymous. #47891

merged 1 commit into from
Jan 31, 2018

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Jan 30, 2018

Fixes #47638 by reverting the addition of readable LLVM trait object type names.
r? @nikomatsakis

@eddyb eddyb added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 30, 2018
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 30, 2018

📌 Commit 973756d has been approved by nikomatsakis

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 31, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Jan 31, 2018
@kennytm
Rollup merge of rust-lang#47891 - eddyb:issue-47638, r=nikomatsakis
bacb5b7 
rustc_trans: keep LLVM types for trait objects anonymous.

Fixes rust-lang#47638 by reverting the addition of readable LLVM trait object type names.
r? @nikomatsakis
@kennytm kennytm mentioned this pull request Jan 31, 2018
Merged
bors added a commit that referenced this pull request Jan 31, 2018
@bors
Auto merge of #47900 - kennytm:rollup, r=kennytm
8ccab7e 
Rollup of 16 pull requests

- Successful merges: #47838, #47840, #47844, #47874, #47875, #47876, #47884, #47886, #47889, #47890, #47891, #47795, #47677, #47893, #47895, #47552
- Failed merges:
@Mark-Simulacrum
Copy link
Member

@bors p=1

@nikomatsakis Can we mark this as beta-accepted? It looks like a small patch which we should backport as soon as possible.

@bors bors merged commit 973756d into rust-lang:master Jan 31, 2018
@eddyb eddyb deleted the issue-47638 branch February 1, 2018 00:12
@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 1, 2018
@nikomatsakis
Copy link
Contributor

Marking as beta-accepted.

@MaloJaffre MaloJaffre mentioned this pull request Feb 1, 2018
Merged
bors added a commit that referenced this pull request Feb 1, 2018
@bors
Auto merge of #47943 - MaloJaffre:beta-backport, r=Mark-Simulacrum
7ec5e9b 
[beta] Backports

Cherry-picked into beta:
- #47762
- #47794
- #47891
bors added a commit that referenced this pull request Feb 2, 2018
@bors
Auto merge of #47943 - MaloJaffre:beta-backport, r=Mark-Simulacrum
6a6b350 
[beta] Backports

Cherry-picked into beta:
- #47762
- #47794
- #47891
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eddyb @nikomatsakis @bors @Mark-Simulacrum @alexcrichton @kennytm