Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable extended tools #48015

Merged
merged 2 commits into from
Feb 10, 2018
Merged

Customizable extended tools #48015

merged 2 commits into from
Feb 10, 2018

Conversation

o01eg
Copy link
Contributor

@o01eg o01eg commented Feb 5, 2018

This PR adds build.tools option to manage installation of extended rust tools.

By default it doesn't change installation. All tools are built and rls and rustfmt allowed to fail installation.

If some set of tools chosen only those tools are built and installed without any fails allowed.

It solves some slotting issues with extended build enabled: https://bugs.gentoo.org/show_bug.cgi?id=645498

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 5, 2018
@nikomatsakis
Copy link
Contributor

r? @Mark-Simulacrum -- code seems fine to me, but I don't feel like the 'owner' of this code

@Mark-Simulacrum
Copy link
Member

r? @alexcrichton

Seems fine to me too, though looks somewhat odd... I'd like @alexcrichton to have a look though since this is dist-related.

@alexcrichton
Copy link
Member

Thanks @o01eg! Mind adding a helper method to do the extended + is a member check? Other than that looks good to go!

@o01eg
Copy link
Contributor Author

o01eg commented Feb 7, 2018

@alexcrichton Added commit with refactoring. I'm waiting installat step to see if something broken. Also I'm not sure about #[allow(dead_code)] but I have no other idea.

@alexcrichton
Copy link
Member

@bors: r+

Looks fine by me!

@bors
Copy link
Contributor

bors commented Feb 7, 2018

📌 Commit 78a0b7f has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2018
@bors
Copy link
Contributor

bors commented Feb 7, 2018

⌛ Testing commit 78a0b7f with merge 4a984fd...

bors added a commit that referenced this pull request Feb 7, 2018
@bors
Auto merge of #48015 - o01eg:disableable-installation, r=alexcrichton
4a984fd 
Customizable extended tools

This PR adds `build.tools` option to manage installation of extended rust tools.

By default it doesn't change installation. All tools are built and `rls` and `rustfmt` allowed to fail installation.

If some set of tools chosen only those tools are built and installed without any fails allowed.

It solves some slotting issues with extended build enabled: https://bugs.gentoo.org/show_bug.cgi?id=645498
@bors
Copy link
Contributor

bors commented Feb 8, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 8, 2018
@kennytm
Copy link
Member

kennytm commented Feb 8, 2018

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Feb 8, 2018
@kennytm
Rollup merge of rust-lang#48015 - o01eg:disableable-installation, r=a…
e732a76 
…lexcrichton

Customizable extended tools

This PR adds `build.tools` option to manage installation of extended rust tools.

By default it doesn't change installation. All tools are built and `rls` and `rustfmt` allowed to fail installation.

If some set of tools chosen only those tools are built and installed without any fails allowed.

It solves some slotting issues with extended build enabled: https://bugs.gentoo.org/show_bug.cgi?id=645498
@kennytm kennytm mentioned this pull request Feb 8, 2018
Closed
bors added a commit that referenced this pull request Feb 8, 2018
@bors
Auto merge of #48077 - kennytm:rollup, r=kennytm
4b3e620 
Rollup of 7 pull requests

- Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064
- Failed merges:
bors added a commit that referenced this pull request Feb 9, 2018
@bors
Auto merge of #48077 - kennytm:rollup, r=kennytm
b29141d 
Rollup of 7 pull requests

- Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064
- Failed merges:
bors added a commit that referenced this pull request Feb 9, 2018
@bors
Auto merge of #48077 - kennytm:rollup, r=kennytm
68df9d6 
Rollup of 12 pull requests

- Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064, #47790, #48059, #48078, #48080, #48085
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Feb 9, 2018
@kennytm
Rollup merge of rust-lang#48015 - o01eg:disableable-installation, r=a…
ebbc35b 
…lexcrichton

Customizable extended tools

This PR adds `build.tools` option to manage installation of extended rust tools.

By default it doesn't change installation. All tools are built and `rls` and `rustfmt` allowed to fail installation.

If some set of tools chosen only those tools are built and installed without any fails allowed.

It solves some slotting issues with extended build enabled: https://bugs.gentoo.org/show_bug.cgi?id=645498
@kennytm kennytm mentioned this pull request Feb 9, 2018
Closed
bors added a commit that referenced this pull request Feb 9, 2018
@bors
Auto merge of #48104 - kennytm:rollup, r=kennytm
394ccaf 
Rollup of 17 pull requests

- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48085, #48086, #48090, #48093, #48098, #48101
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Feb 10, 2018
@kennytm
Rollup merge of rust-lang#48015 - o01eg:disableable-installation, r=a…
077979f 
…lexcrichton

Customizable extended tools

This PR adds `build.tools` option to manage installation of extended rust tools.

By default it doesn't change installation. All tools are built and `rls` and `rustfmt` allowed to fail installation.

If some set of tools chosen only those tools are built and installed without any fails allowed.

It solves some slotting issues with extended build enabled: https://bugs.gentoo.org/show_bug.cgi?id=645498
@kennytm kennytm mentioned this pull request Feb 10, 2018
Merged
bors added a commit that referenced this pull request Feb 10, 2018
@bors
Auto merge of #48113 - kennytm:rollup, r=kennytm
d5e3164 
Rollup of 16 pull requests

- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100
- Failed merges:
bors added a commit that referenced this pull request Feb 10, 2018
@bors
Auto merge of #48113 - kennytm:rollup, r=kennytm
45fba43 
Rollup of 20 pull requests

- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100, #48085, #48120, #48124, #47547
- Failed merges:
@bors bors merged commit 78a0b7f into rust-lang:master Feb 10, 2018
@o01eg o01eg deleted the disableable-installation branch February 11, 2018 09:55
@o01eg o01eg mentioned this pull request Feb 11, 2018
Closed
@o01eg o01eg mentioned this pull request Jan 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@o01eg @rust-highfive @nikomatsakis @Mark-Simulacrum @alexcrichton @bors @kennytm @pietroalbini