Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo: substract -> subtract #48107

Merged
merged 1 commit into from
Feb 10, 2018
Merged

fix typo: substract -> subtract #48107

merged 1 commit into from
Feb 10, 2018

Conversation

matthiaskrgr
Copy link
Member

No description provided.

kennytm
kennytm reviewed Feb 9, 2018
View reviewed changes
Copy link
Member

@kennytm kennytm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after fixing the error or Travis is green

src/test/ui/mismatched_types/binops.stderr Outdated
@@ -47,4 +47,3 @@ error[E0277]: the trait bound `{integer}: std::cmp::PartialEq<std::result::Resul
= help: the trait `std::cmp::PartialEq<std::result::Result<{integer}, _>>` is not implemented for `{integer}`

error: aborting due to 6 previous errors

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing new line is accidentally deleted

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 9, 2018
@matthiaskrgr matthiaskrgr force-pushed the typo__substract_to_subtract branch from 35f03e8 to e6f910e Compare February 9, 2018 23:56
@estebank
Copy link
Contributor

@bors r=kennytm rollup

@bors
Copy link
Contributor

bors commented Feb 10, 2018

📌 Commit e6f910e has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Feb 10, 2018
@kennytm
Rollup merge of rust-lang#48107 - matthiaskrgr:typo__substract_to_sub…
6605d03 
…tract, r=kennytm

fix typo: substract -> subtract
@kennytm kennytm mentioned this pull request Feb 10, 2018
Merged
bors added a commit that referenced this pull request Feb 10, 2018
@bors
Auto merge of #48113 - kennytm:rollup, r=kennytm
d5e3164 
Rollup of 16 pull requests

- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100
- Failed merges:
bors added a commit that referenced this pull request Feb 10, 2018
@bors
Auto merge of #48113 - kennytm:rollup, r=kennytm
45fba43 
Rollup of 20 pull requests

- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100, #48085, #48120, #48124, #47547
- Failed merges:
@bors bors merged commit e6f910e into rust-lang:master Feb 10, 2018
@matthiaskrgr matthiaskrgr deleted the typo__substract_to_subtract branch February 10, 2018 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthiaskrgr @estebank @bors @kennytm