Update RELEASES.md for 1.25.0 #48374

XAMPPRocky · 2018-02-20T16:36:42Z

rust-highfive · 2018-02-20T16:36:53Z

(rust_highfive has picked a reviewer for you, use r? to override)

steveklabnik · 2018-02-20T16:39:17Z

RELEASES.md

+- [`UnsafeCell::into_inner` is now safe.][47204]
+- [Implement libstd for CloudABI.][47268]
+- [`Float::{from_bits, to_bits}` is now available in libcore.][46931]
+- [renamed `ptr::Shared` to `ptr::NonNull`.][46952]


this isn't stable yet, so probably shouldn't be in here, right?

@steveklabnik Looking at the beta docs and the prs this mentioned in. It's stable this release unless there was a revert pr I didn't see.

Maybe don't mention ptr::Shared?

yeah, I would make this link to the stabilization of NonNull in that case.

steveklabnik · 2018-02-20T16:40:18Z

RELEASES.md

+- The borrow checker was sometimes incorrectly permitting overlapping borrows
+  around indexing operations (see #47349). This has been fixed (which also
+  enabled some correct code that used to cause errors (e.g. #33903 and #46095).
+- [Removed deprecated unstable attribute `#[simd]`.][47251]


@steveklabnik @Mark-Simulacrum gave it the relnotes tag so I included it.

kennytm · 2018-02-20T19:36:11Z

RELEASES.md

+- [`Float::{from_bits, to_bits}` is now available in libcore.][46931]
+- [renamed `ptr::Shared` to `ptr::NonNull`.][46952]
+- [Implement `AsRef<Path>` for Component][46985]
+- [Deprecated `[T]::rotate` in favor of `[T]::rotate_{left,right}`.][46777]


rotate_left and rotate_right are not stable yet.

kennytm · 2018-02-20T19:37:20Z

RELEASES.md

+- [`rustdoc` has switched to pulldown as the default markdown renderer.][47398]
+- The borrow checker was sometimes incorrectly permitting overlapping borrows
+  around indexing operations (see #47349). This has been fixed (which also
+  enabled some correct code that used to cause errors (e.g. #33903 and #46095).


Please add links to these 3 issues.

kennytm · 2018-02-20T19:37:48Z

RELEASES.md

+- [`UnsafeCell::into_inner` is now safe.][47204]
+- [Implement libstd for CloudABI.][47268]
+- [`Float::{from_bits, to_bits}` is now available in libcore.][46931]
+- [renamed `ptr::Shared` to `ptr::NonNull`.][46952]


Maybe don't mention ptr::Shared?

nikomatsakis · 2018-02-20T20:43:53Z

r? @Mark-Simulacrum

Mark-Simulacrum · 2018-02-20T21:03:47Z

RELEASES.md

+--------
+- [Stabilised `#[repr(align(x))]`.][47006] [RFC 1358]
+- [You can now use nested groups of imports.][47948]
+  eg. `use std::{fs::File, io::Read, path::{Path, PathBuf}};`


We should probably use e.g. instead of eg. throughout.

JordiPolo · 2018-02-22T04:45:55Z

RELEASES.md

+[cargo/5029]: https://github.com/rust-lang/cargo/pull/5029
+[RFC 1358]: https://github.com/rust-lang/rfcs/pull/1358
+[`Location::column`]: https://doc.rust-lang.org/std/panic/struct.Location.html#method.column
+[`ptr::NonNull`]: https://doc.rust-lang.org/std/ptr/struct.NonNull.html


link returns 404?

The link should be available once 1.25 is released to stable channel.

JordiPolo · 2018-02-22T04:46:10Z

RELEASES.md

+-----
+- [`cargo new` no longer removes `rust` or `rs` prefixs/suffixs.][cargo/5013]
+- [`cargo new` now defaults to creating a binary crate, instead of a
+  libary crate.][cargo/5029]


libary -> library

shepmaster · 2018-03-02T22:56:10Z

Ping from triage, @Mark-Simulacrum — looks like it's back in your court!

Mark-Simulacrum · 2018-03-08T03:13:54Z

RELEASES.md

+- [`UnsafeCell::into_inner` is now safe.][47204]
+- [Implement libstd for CloudABI.][47268]
+- [`Float::{from_bits, to_bits}` is now available in libcore.][46931]
+


Extra line?

Mark-Simulacrum · 2018-03-08T03:14:20Z

RELEASES.md

+
+Misc
+----
+


Should probably remove this category if it's unused.

Havvy · 2018-03-11T05:25:35Z

Isn't this going to be the first release with Rust By Example in the distribution documentation? Shouldn't that be in the release notes?

XAMPPRocky · 2018-03-11T12:42:34Z

@Havvy Do you have the PR that does that so I can check if it's in beta?

steveklabnik · 2018-03-11T19:40:32Z

#46196

but easier: https://doc.rust-lang.org/beta/rust-by-example/

The PR was marked relnotes...

shepmaster · 2018-03-18T16:37:45Z

Ping from triage, @Mark-Simulacrum — looks like it's back in your court!

Mark-Simulacrum · 2018-03-18T21:25:22Z

Looks like my two nits still stand (#48374 (review)). Otherwise I think we are good to merge.

XAMPPRocky · 2018-03-19T12:38:53Z

@Mark-Simulacrum I've removed the extra line, and Misc is no longer empty so it shouldn't be removed.

Mark-Simulacrum · 2018-03-21T21:06:36Z

@bors r+ p=1

bors · 2018-03-21T21:06:37Z

📌 Commit e2cf172 has been approved by Mark-Simulacrum

bors · 2018-03-21T21:06:37Z

🌲 The tree is currently closed for pull requests below priority 30, this pull request will be tested once the tree is reopened

Update RELEASES.md for 1.25.0 [rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

pietroalbini · 2018-03-21T23:18:49Z

@bors rollup

Update RELEASES.md for 1.25.0 [rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

Rollup of 23 pull requests - Successful merges: #48374, #48596, #48759, #48939, #49029, #49069, #49093, #49109, #49117, #49140, #49158, #49188, #49189, #49209, #49211, #49216, #49225, #49231, #49234, #49242, #49244, #49105, #49038 - Failed merges:

rust-highfive assigned nikomatsakis Feb 20, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 20, 2018

Update RELEASES.md for 1.25.0

312e53d

XAMPPRocky force-pushed the master branch from bf9ebbb to 312e53d Compare February 20, 2018 16:37

steveklabnik reviewed Feb 20, 2018

View reviewed changes

kennytm reviewed Feb 20, 2018

View reviewed changes

Update RELEASES.md

1f3b626

rust-highfive assigned Mark-Simulacrum and unassigned nikomatsakis Feb 20, 2018

Mark-Simulacrum requested changes Feb 20, 2018

View reviewed changes

kennytm added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Feb 21, 2018

JordiPolo reviewed Feb 22, 2018

View reviewed changes

Update RELEASES.md

acc1b6d

Mark-Simulacrum requested changes Mar 8, 2018

View reviewed changes

goodmanjonathan mentioned this pull request Mar 10, 2018

Fixes for the match grammar rust-lang/reference#262

Merged

Update RELEASES.md

f83618b

Update RELEASES.md

e2cf172

Mark-Simulacrum approved these changes Mar 21, 2018

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2018

kennytm added a commit to kennytm/rust that referenced this pull request Mar 21, 2018

Rollup merge of rust-lang#48374 - Aaronepower:master, r=Mark-Simulacrum

fc801dc

Update RELEASES.md for 1.25.0 [rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

kennytm mentioned this pull request Mar 21, 2018

Rollup of 20 pull requests #49236

Closed

kennytm added a commit to kennytm/rust that referenced this pull request Mar 22, 2018

Rollup merge of rust-lang#48374 - Aaronepower:master, r=Mark-Simulacrum

d313700

Update RELEASES.md for 1.25.0 [rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

kennytm mentioned this pull request Mar 22, 2018

Rollup of 23 pull requests #49264

Merged

alexcrichton merged commit e2cf172 into rust-lang:master Mar 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update RELEASES.md for 1.25.0 #48374

Update RELEASES.md for 1.25.0 #48374

XAMPPRocky commented Feb 20, 2018

rust-highfive commented Feb 20, 2018

steveklabnik Feb 20, 2018

XAMPPRocky Feb 20, 2018

kennytm Feb 20, 2018

steveklabnik Feb 20, 2018

steveklabnik Feb 20, 2018

XAMPPRocky Feb 20, 2018

kennytm Feb 20, 2018

kennytm Feb 20, 2018

kennytm Feb 20, 2018

nikomatsakis commented Feb 20, 2018

Mark-Simulacrum Feb 20, 2018

JordiPolo Feb 22, 2018

kennytm Feb 22, 2018

JordiPolo Feb 22, 2018

shepmaster commented Mar 2, 2018

Mark-Simulacrum Mar 8, 2018

Mark-Simulacrum Mar 8, 2018

Havvy commented Mar 11, 2018

XAMPPRocky commented Mar 11, 2018

steveklabnik commented Mar 11, 2018

shepmaster commented Mar 18, 2018

Mark-Simulacrum commented Mar 18, 2018

XAMPPRocky commented Mar 19, 2018

Mark-Simulacrum commented Mar 21, 2018

bors commented Mar 21, 2018

bors commented Mar 21, 2018

pietroalbini commented Mar 21, 2018


		Misc
		----

Update RELEASES.md for 1.25.0 #48374

Update RELEASES.md for 1.25.0 #48374

Conversation

XAMPPRocky commented Feb 20, 2018

rust-highfive commented Feb 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikomatsakis commented Feb 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shepmaster commented Mar 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Havvy commented Mar 11, 2018

XAMPPRocky commented Mar 11, 2018

steveklabnik commented Mar 11, 2018

shepmaster commented Mar 18, 2018

Mark-Simulacrum commented Mar 18, 2018

XAMPPRocky commented Mar 19, 2018

Mark-Simulacrum commented Mar 21, 2018

bors commented Mar 21, 2018

bors commented Mar 21, 2018

pietroalbini commented Mar 21, 2018