Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix events handling in rustdoc #49152

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Fix events handling in rustdoc #49152

merged 1 commit into from
Mar 20, 2018

Conversation

GuillaumeGomez
Copy link
Member

Fixes #49075.

@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2018
@GuillaumeGomez
Copy link
Member Author

r? @QuietMisdreavus

@QuietMisdreavus
Copy link
Member

Good catch, thanks!

@bors r+

@QuietMisdreavus
Copy link
Member

bors was down earlier, let's see if this works now...

@bors r+

@bors
Copy link
Contributor

bors commented Mar 19, 2018

📌 Commit 5581aa8 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2018
@kennytm kennytm mentioned this pull request Mar 19, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Mar 20, 2018
@kennytm
Rollup merge of rust-lang#49152 - GuillaumeGomez:rustdoc-event-handli…
45de057 
…ng, r=QuietMisdreavus

Fix events handling in rustdoc

Fixes rust-lang#49075.
bors added a commit that referenced this pull request Mar 20, 2018
@bors
Auto merge of #49190 - kennytm:rollup, r=kennytm
75af15e 
Rollup of 17 pull requests

- Successful merges: #46518, #48810, #48834, #48902, #49004, #49092, #49096, #49099, #49104, #49125, #49139, #49152, #49157, #49161, #49166, #49176, #49184
- Failed merges:
@bors
Copy link
Contributor

bors commented Mar 20, 2018

☔ The latest upstream changes (presumably #49190) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 20, 2018
@bors bors merged commit 5581aa8 into rust-lang:master Mar 20, 2018
@GuillaumeGomez GuillaumeGomez deleted the rustdoc-event-handling branch March 21, 2018 09:07
@onur onur mentioned this pull request Mar 28, 2018
Closed
@nagisa nagisa mentioned this pull request Apr 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @rust-highfive @QuietMisdreavus @bors @steveklabnik