-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 17 pull requests #49190
Merged
Merged
Rollup of 17 pull requests #49190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ship libsynchronization from MinGW
This subsumes the need for an explicit is_empty function, and provides access to the buffered data itself which has been requested from time to time.
- `suggest_snippet` handling space between refs; - Suggest message changing according to the number of refs that should be removed.
Suggesting snippet without changing the original formatting of the code.
- `span_suggestion` changed to `span_suggestion_short`; - `Span` used changed to contain only `&` refs; - Tests passing.
- Using `span_take_while` to implement others.
…apin Add BufReader::buffer This subsumes the need for an explicit is_empty function, and provides access to the buffered data itself which has been requested from time to time. We could call this `buf` to match `fill_buf`, but I think I'd prefer `fill_buffer` anyways in hindsight.
@bors r+ p=18 |
📌 Commit 3972e74 has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Mar 19, 2018
⌛ Testing commit 3972e74850831e91276d6d477cbb89507889e51c with merge 315f4e600aede729e2fccdd4471faaa35808908c... |
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 20, 2018
…ng, r=QuietMisdreavus Fix events handling in rustdoc Fixes rust-lang#49075.
Do not suggest `.into()` in `const`s Fix rust-lang#49100.
…rAus Docs: fix incorrect copy-paste for new `X?` in formatting strings
rust-lang#49133 - Reworded the Error message: "`pub` not needed here" message
…lto, r=alexcrichton config.toml.example: thinlto bootstrap was removed It was removed in ff227c4 so remove the option that no longer works (we did not notice because it was commented out by default).
…xcrichton Update beta to version with fixed FreeBSD support from rust-lang#49023. Fixes rust-lang#42681 r? @alexcrichton
📌 Commit 57b8211 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 20, 2018
bors
added a commit
that referenced
this pull request
Mar 20, 2018
☀️ Test successful - status-appveyor, status-travis |
This was referenced Mar 20, 2018
This was referenced Mar 20, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&
s #48834, refactor theBorrowckErrors
trait to takefn(self)
#48902, Cache the specialization_graph query #49004, Replace many of the last references to readmes #49092, Update rustfmt to 0.4.1 #49096, Use associated consts for GenericRadix base and prefix #49099, improve error message of inner attribute syntax #49104, rustbuild: Ship libsynchronization #49125, Add BufReader::buffer #49139, Fix events handling in rustdoc #49152, Do not suggest.into()
inconst
s #49157, Docs: fix incorrect copy-paste for newX?
in formatting strings #49161, #49133 - Reworded the Error message: "pub
not needed here" message #49166, config.toml.example: thinlto bootstrap was removed #49176, Update beta to version with fixed FreeBSD support from #49023. #49184