update miri #52338

RalfJung · 2018-07-13T08:36:55Z

No description provided.

rust-highfive · 2018-07-13T08:37:05Z

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2018-07-13T08:37:06Z

Warning

These commits modify submodules.

rust-highfive · 2018-07-13T10:04:30Z

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0aedaf82:start=1531476244385073539,finish=1531476244392210173,duration=7136634
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0b85eb38
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0118ce60
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

RalfJung · 2018-07-13T10:12:48Z

$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory

and

[01:25:45] 1 command(s) did not execute successfully:
[01:25:45] 
[01:25:45]   - "/checkout/obj/build/bootstrap/debug/rustdoc" "--test" "/checkout/src/doc/nomicon/src/vec-final.md" "--test-args" ""

That's not introduced by this PR, is it?

oli-obk · 2018-07-13T12:10:42Z

cc @kennytm maybe related to all submodules successfully passing CI? 😆

oli-obk · 2018-07-13T12:11:03Z

@bors r+ p=1

let's see if bors likes this better

bors · 2018-07-13T12:11:04Z

📌 Commit 817c5783b03a6ad17bfa608f3c5c7a800bbd2ddd has been approved by oli-obk

bors · 2018-07-13T12:19:48Z

⌛ Testing commit 817c5783b03a6ad17bfa608f3c5c7a800bbd2ddd with merge 51d30eef406bc0c6cfd4a175ae23b280927a2c25...

bors · 2018-07-13T13:27:54Z

💔 Test failed - status-appveyor

oli-obk · 2018-07-13T13:33:34Z

A bunch of tests are failing on windows:

error[E0080]: constant evaluation error
  --> C:\projects\rust\src\libstd\sys\windows\stack_overflow.rs:45:8
   |
45 |     if c::AddVectoredExceptionHandler(0, vectored_handler).is_null() {
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no mir for `std::sys::windows::c::::AddVectoredExceptionHandler`
   |
note: inside call to `std::sys::windows::stack_overflow::init`
  --> C:\projects\rust\src\libstd\rt.rs:44:9
   |
44 |         sys::stack_overflow::init();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: inside call to `std::rt::lang_start_internal`
  --> C:\projects\rust\src\libstd\rt.rs:74:5
   |
74 |     lang_start_internal(&move || main().report(), argc, argv)
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: aborting due to previous error

rust-highfive · 2018-07-13T13:41:34Z

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0209b6f8:start=1531489291273393734,finish=1531489291280369674,duration=6975940
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00146ae4
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:07c93662
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

RalfJung · 2018-07-13T15:50:51Z

Needs a fix on Windows, which is being developed at rust-lang/miri#401

RalfJung · 2018-07-15T10:57:04Z

Blocked by #52400

kennytm · 2018-07-16T08:54:04Z

#52400 has been merged.

RalfJung · 2018-07-16T09:29:33Z

Yep, now this is blocked on rust-lang/miri#401 :)

kennytm · 2018-07-16T18:09:12Z

@bors r-

#52433 (comment) — miri is broken by #52264.

RalfJung · 2018-07-17T07:14:27Z

All right, miri should be fixed (again). Let's hope nobody else breaks it this time. ;)

oli-obk · 2018-07-17T07:43:47Z

@bors r+ p=1

bors · 2018-07-17T07:43:48Z

📌 Commit 358b88ca1e8fd72b82aef528032db2e7e06fee99 has been approved by oli-obk

rust-highfive · 2018-07-17T08:42:39Z

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2018-07-17T09:26:16Z

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

git checkout miri (switch to your branch)
git fetch upstream master (retrieve the latest master)
git rebase upstream/master -p (rebase on top of it)
Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
git push self miri --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

warning: Cannot merge binary files: src/Cargo.lock (HEAD vs. heads/homu-tmp)
Auto-merging src/Cargo.lock
CONFLICT (content): Merge conflict in src/Cargo.lock
Automatic merge failed; fix conflicts and then commit the result.

RalfJung · 2018-07-17T09:43:16Z

Rebased.

@bors r=oli-obk

bors · 2018-07-17T09:43:16Z

@RalfJung: 🔑 Insufficient privileges: Not in reviewers

oli-obk · 2018-07-17T09:46:25Z

@bors r+

bors · 2018-07-17T09:46:26Z

📌 Commit 9e10b12 has been approved by oli-obk

update miri

nikomatsakis · 2018-07-17T12:37:02Z

cc @alexcrichton -- any idea why @RalfJung doesn't have review privileges, given rust-lang/rust-central-station#72?

@ghost

Rollup of 9 pull requests Successful merges: - #52286 (Deny bare trait objects in src/librustc_errors) - #52306 (Reduce the number of clone()s needed in obligation_forest) - #52338 (update miri) - #52385 (Pass edition flags to compiler from rustdoc as expected) - #52392 (AsRef doc wording tweaks) - #52430 (update nomicon) - #52434 (Enable incremental independent of stage) - #52435 (Calculate the exact capacity for 2 HashMaps) - #52446 (Block beta if clippy breaks.) r? @ghost

bors · 2018-07-17T15:39:29Z

⌛ Testing commit 9e10b12 with merge 4bff385...

rust-highfive assigned alexcrichton Jul 13, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 13, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2018

kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 13, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jul 16, 2018

kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 16, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 16, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 17, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 17, 2018

RalfJung added 3 commits July 17, 2018 11:40

update miri

f684f80

update miri (Windows tests fixed)

114dc69

update miri

9e10b12

RalfJung force-pushed the miri branch from 358b88c to 9e10b12 Compare July 17, 2018 09:42

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 17, 2018

This comment has been minimized.

Sign in to view

kennytm added a commit to kennytm/rust that referenced this pull request Jul 17, 2018

Rollup merge of rust-lang#52338 - RalfJung:miri, r=oli-obk

a07f213

update miri

bors merged commit 9e10b12 into rust-lang:master Jul 17, 2018

RalfJung deleted the miri branch July 23, 2018 09:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update miri #52338

update miri #52338

RalfJung commented Jul 13, 2018

rust-highfive commented Jul 13, 2018

rust-highfive commented Jul 13, 2018

rust-highfive commented Jul 13, 2018

RalfJung commented Jul 13, 2018 •

edited

Loading

oli-obk commented Jul 13, 2018

oli-obk commented Jul 13, 2018

bors commented Jul 13, 2018

bors commented Jul 13, 2018

bors commented Jul 13, 2018

oli-obk commented Jul 13, 2018

rust-highfive commented Jul 13, 2018

RalfJung commented Jul 13, 2018

RalfJung commented Jul 15, 2018

kennytm commented Jul 16, 2018

RalfJung commented Jul 16, 2018

kennytm commented Jul 16, 2018 •

edited

Loading

RalfJung commented Jul 17, 2018

oli-obk commented Jul 17, 2018

bors commented Jul 17, 2018

rust-highfive commented Jul 17, 2018

bors commented Jul 17, 2018

RalfJung commented Jul 17, 2018

bors commented Jul 17, 2018

oli-obk commented Jul 17, 2018

bors commented Jul 17, 2018

This comment has been minimized.

nikomatsakis commented Jul 17, 2018

bors commented Jul 17, 2018

update miri #52338

update miri #52338

Conversation

RalfJung commented Jul 13, 2018

rust-highfive commented Jul 13, 2018

rust-highfive commented Jul 13, 2018

rust-highfive commented Jul 13, 2018

RalfJung commented Jul 13, 2018 • edited Loading

oli-obk commented Jul 13, 2018

oli-obk commented Jul 13, 2018

bors commented Jul 13, 2018

bors commented Jul 13, 2018

bors commented Jul 13, 2018

oli-obk commented Jul 13, 2018

rust-highfive commented Jul 13, 2018

RalfJung commented Jul 13, 2018

RalfJung commented Jul 15, 2018

kennytm commented Jul 16, 2018

RalfJung commented Jul 16, 2018

kennytm commented Jul 16, 2018 • edited Loading

RalfJung commented Jul 17, 2018

oli-obk commented Jul 17, 2018

bors commented Jul 17, 2018

rust-highfive commented Jul 17, 2018

bors commented Jul 17, 2018

RalfJung commented Jul 17, 2018

bors commented Jul 17, 2018

oli-obk commented Jul 17, 2018

bors commented Jul 17, 2018

This comment has been minimized.

nikomatsakis commented Jul 17, 2018

bors commented Jul 17, 2018

RalfJung commented Jul 13, 2018 •

edited

Loading

kennytm commented Jul 16, 2018 •

edited

Loading