Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nomicon #52430

Merged
merged 1 commit into from
Jul 17, 2018
Merged

update nomicon #52430

merged 1 commit into from
Jul 17, 2018

Conversation

RalfJung
Copy link
Member

Will this trigger a website update automatically or is that a separate step?

@rust-highfive
Copy link
Collaborator

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2018
@kennytm
Copy link
Member

kennytm commented Jul 16, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 16, 2018

📌 Commit 21a1796 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2018
@Mark-Simulacrum
Copy link
Member

Yes, this'll update the nightly docs with the next nightly release.

@RalfJung
Copy link
Member Author

Note that I had to update travis.yml to pin an older version of mdbook in the nomicon to make CI pass, will this be picked up here or will it still use the latest mdbook?

See rust-lang/mdBook#724

@steveklabnik
Copy link
Member

steveklabnik commented Jul 16, 2018 via email

@RalfJung
Copy link
Member Author

Ah, and as @kennytm pointed out bootstrap just walks all *.md files and tests those with rustdoc directly.

kennytm added a commit to kennytm/rust that referenced this pull request Jul 17, 2018
update nomicon

Will this trigger a website update automatically or is that a separate step?
bors added a commit that referenced this pull request Jul 17, 2018
Rollup of 9 pull requests

Successful merges:

 - #52286 (Deny bare trait objects in src/librustc_errors)
 - #52306 (Reduce the number of clone()s needed in obligation_forest)
 - #52338 (update miri)
 - #52385 (Pass edition flags to compiler from rustdoc as expected)
 - #52392 (AsRef doc wording tweaks)
 - #52430 (update nomicon)
 - #52434 (Enable incremental independent of stage)
 - #52435 (Calculate the exact capacity for 2 HashMaps)
 - #52446 (Block beta if clippy breaks.)

r? @ghost
@bors bors merged commit 21a1796 into rust-lang:master Jul 17, 2018
@RalfJung RalfJung deleted the nomicon branch July 23, 2018 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants