Cleanup some rustdoc code #52628

Mark-Simulacrum · 2018-07-22T20:43:55Z

Commits are mostly individual though some do depend on others.

rust-highfive · 2018-07-22T20:43:58Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2018-07-22T21:01:29Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.


[00:03:58] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:59] tidy error: /checkout/src/librustdoc/html/markdown.rs:844: XXX is deprecated; use FIXME
[00:04:00] some tidy checks failed
[00:04:00] 
[00:04:00] 
[00:04:00] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:00] 
[00:04:00] 
[00:04:00] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:00] Build completed unsuccessfully in 0:00:53
[00:04:00] Build completed unsuccessfully in 0:00:53
[00:04:00] Makefile:79: recipe for target 'tidy' failed
[00:04:00] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0b9f94b6
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:01660f34:start=1532292783949817341,finish=1532292783956618836,duration=6801495
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:02b8459c
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:27e73cb4
travis_time:start:27e73cb4
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0df5fd8b
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-07-22T21:50:22Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:41:00] Makefile:28: rec1972296
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:05506c60
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:172cc1be
travis_time:start:172cc1be
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-07-22T22:12:21Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.


[00:03:57] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:58] tidy error: /checkout/src/tools/error_index_generator/main.rs:106: line longer than 100 chars
[00:03:59] some tidy checks failed
[00:03:59] 
[00:03:59] 
[00:03:59] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:59] 
[00:03:59] 
[00:03:59] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:59] Build completed unsuccessfully in 0:00:52
[00:03:59] Build completed unsuccessfully in 0:00:52
[00:03:59] Makefile:79: recipe for target 'tidy' failed
[00:03:59] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:132651c0
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:1a8e663c:start=1532297085996382739,finish=1532297086008253235,duration=11870496
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:180df7a6
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:01d6f218
travis_time:start:01d6f218
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:317af98d
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

steveklabnik · 2018-07-23T13:17:22Z

I like it! I'll let @rust-lang/rustdoc review though :)

GuillaumeGomez · 2018-07-23T14:58:13Z

I went very quickly through the code and it seems nice. But could it wait for #52585 to be merged first please? It'd make my life so much easier!

Mark-Simulacrum · 2018-07-23T15:05:06Z

Yep, this can wait. I'll rebase.

QuietMisdreavus · 2018-07-23T15:46:58Z

Where does this PR stand with #52630? Or #52257? Or the recently-merged #52211? There have been several PRs opened recently to clean up or refactor rustdoc, and i'm not sure there has been much coordination between the people who opened them.

Mark-Simulacrum · 2018-07-23T16:18:39Z

#52630 is mostly orthogonal. #52257 looks also different; #52211 also is orthogonal. I believe we all coincidentally found different areas to polish :)

Mark-Simulacrum · 2018-07-28T23:04:12Z

Rebased.

rust-highfive · 2018-07-29T00:10:21Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-07-29T01:37:47Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:20:02] 
[01:20:02] 12 3 | no
[01:20:02] 13   | ^^ not found in this scope
[01:20:02] 14 
[01:20:02] - thread '$DIR/failed-doctest-output.rs - OtherStruct (line 26)' panicked at 'couldn't compile the test', librustdoc/test.rs:332:13
[01:20:02] + thread '$DIR/failed-doctest-output.rs - OtherStruct (line 26)' panicked at 'couldn't compile the test', librustdoc/test.rs:333:13
[01:20:02] 17 
[01:20:02] 17 
[01:20:02] 18 ---- $DIR/failed-doctest-output.rs - SomeStruct (line 20) stdout ----
[01:20:02] 
[01:20:02] 21 thread 'main' panicked at 'oh no', $DIR/failed-doctest-output.rs:3:1
[01:20:02] 23 
[01:20:02] - ', librustdoc/test.rs:367:17
[01:20:02] + ', librustdoc/test.rs:368:17
[01:20:02] 25 
[01:20:02] 25 
[01:20:02] 26 
[01:20:02] 27 failures:
[01:20:02] 
[01:20:02] 
[01:20:02] The actual stdout differed from the expected stdout.
[01:20:02] Actual stdout saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/failed-doctest-output/failed-doctest-output.stdout
[01:20:02] To update references, rerun the tests and pass the `--bless` flag
[01:20:02] To only update this specific test, also pass `--test-args failed-doctest-output.rs`
[01:20:02] error: 1 errors occurred comparing output.
[01:20:02] status: exit code: 101
[01:20:02] status: exit code: 101
[01:20:02] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "/checkout/src/test/rustdoc-ui/failed-doctest-output.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/failed-doctest-output/a" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--test" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/failed-doctest-output/auxiliary"
[01:20:02] ------------------------------------------
[01:20:02] 
[01:20:02] running 2 tests
[01:20:02] test /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - OtherStruct (line 26) ... FAILED
[01:20:02] test /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - OtherStruct (line 26) ... FAILED
[01:20:02] test /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - SomeStruct (line 20) ... FAILED
[01:20:02] failures:
[01:20:02] 
[01:20:02] ---- /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - OtherStruct (line 26) stdout ----
[01:20:02] ---- /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - OtherStruct (line 26) stdout ----
[01:20:02] error[E0425]: cannot find value `no` in this scope
[01:20:02]   |
[01:20:02] 3 | no
[01:20:02]   | ^^ not found in this scope
[01:20:02] 
[01:20:02] 
[01:20:02] thread '/checkout/src/test/rustdoc-ui/failed-doctest-output.rs - OtherStruct (line 26)' panicked at 'couldn't compile the test', librustdoc/test.rs:333:13
[01:20:02] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:20:02] 
[01:20:02] ---- /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - SomeStruct (line 20) stdout ----
[01:20:02] thread '/checkout/src/test/rustdoc-ui/failed-doctest-output.rs - SomeStruct (line 20)' panicked at 'test executab/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/rustdoc-ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Zunstable-options " "--target-rustcflags" "-Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:20:02] 
[01:20:02] 
[01:20:02] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:20:02] Build completed unsuccessfully in 0:34:30
[01:20:02] Build completed unsuccessfully in 0:34:30
[01:20:02] Makefile:58: recipe for target 'check' failed
[01:20:02] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:09df34f2
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

GuillaumeGomez · 2018-07-29T09:48:19Z

Looks good to me, thanks! I'd like to have @QuietMisdreavus's confirmation too so let's wait for their reviews. :)

QuietMisdreavus · 2018-07-31T16:45:14Z

Looks good to me! GitHub is reporting some merge conflicts; r=me with those resolved.

Parsing the code block's LangString (```foo) previously checked itself to see if we were on nightly; that isn't the right place to do so. Move that check slightly outwards to better abstract LangString. (This is also an optimization as we avoid the costly environment variable load of RUSTC_BOOTSTRAP).

Previously we would only warn on Rust code but we can also do so when testing markdown (the diag::Handler is available).

This is far more sound than passing many different arguments of the same type.

Removes dependency on UnstableFeatures from markdown rendering

Mark-Simulacrum · 2018-07-31T17:42:14Z

@bors r=QuietMisdreavus

bors · 2018-07-31T17:42:15Z

📌 Commit 67e699fb1c7b9808e2091b228653d318a4d6870d has been approved by QuietMisdreavus

rust-highfive · 2018-07-31T19:07:10Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:13:10]    Compiling rustdoc v0.0.0 (file:///checkout/src/librustdoc)
[01:13:14] error[E0308]: mismatched types
[01:13:14]    --> librustdoc/html/markdown.rs:973:9
[01:13:14]     |
[01:13:14] 973 |         Markdown(markdown, &[], RefCell::new(&mut map), ErrorCodes::Yes).to_string()
[01:13:14]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected (), found struct `std::string::String`
[01:13:14]     = note: expected type `()`
[01:13:14]                found type `std::string::String`
[01:13:14] help: try adding a semicolon
[01:13:14]     |
[01:13:14]     |
[01:13:14] 973 |         Markdown(markdown, &[], RefCell::new(&mut map), ErrorCodes::Yes).to_string();
[01:13:14] help: try adding a return type
[01:13:14]     |
[01:13:14] 970 |     fn issue_17736() -> std::string::String {
[01:13:14]     |                      ^^^^^^^^^^^^^^^^^^^^^^
---
[01:13:16] 
[01:13:16] To learn more, run the command again with --verbose.
[01:13:16] 
[01:13:16] 
[01:13:16] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/rustdoc/Cargo.toml" "-p" "rustdoc:0.0.0" "--" "--quiet"
[01:13:16] 
[01:13:16] 
[01:13:16] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:13:16] Build completed unsuccessfully in 0:28:59
[01:13:16] Build completed unsuccessfully in 0:28:59
[01:13:16] Makefile:58: recipe for target 'check' failed
[01:13:16] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:053d86be
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0ccabd24:start=1533064015851188629,finish=1533064015858108174,duration=6919545
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:050590b0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:195d028c
travis_time:start:195d028c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:09c66a52
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Mark-Simulacrum · 2018-07-31T19:27:01Z

@bors r-

Previously these functions relied on TLS but we can instead thread the relevant state through explicitly.

Removes some unused code and de-publicizes structs

Mark-Simulacrum · 2018-07-31T23:55:38Z

@bors r=QuietMisdreavus

bors · 2018-07-31T23:55:39Z

📌 Commit 0f680b3 has been approved by QuietMisdreavus

…r=QuietMisdreavus Cleanup some rustdoc code Commits are mostly individual though some do depend on others.

@ghost

Rollup of 31 pull requests Successful merges: - #52332 (dead-code lint: say "constructed" for structs) - #52340 (Document From trait implementations for OsStr, OsString, CString, and CStr) - #52628 (Cleanup some rustdoc code) - #52732 (Remove unstable and deprecated APIs) - #52745 (Update clippy to latest master) - #52756 (rustc: Disallow machine applicability in foreign macros) - #52771 (Clarify thread::park semantics) - #52810 ([NLL] Don't make "fake" match variables mutable) - #52821 (pretty print for std::collections::vecdeque) - #52822 (Fix From<LocalWaker>) - #52824 (Fix -Wpessimizing-move warnings in rustllvm/PassWrapper) - #52831 (remove references to AUTHORS.txt file) - #52835 (Fix Alias intra doc ICE) - #52842 (update comment) - #52846 (Add timeout to use of `curl` in bootstrap.py.) - #52851 (Make the tool_lints actually usable) - #52853 (Improve bootstrap help on stages) - #52859 (Use Vec::extend in SmallVec::extend when applicable) - #52861 (Add targets for HermitCore (https://hermitcore.org) to the Rust compiler and port libstd to it.) - #52867 (releases.md: fix 2 typos) - #52870 (Implement Unpin for FutureObj and LocalFutureObj) - #52876 (run-pass/const-endianness: negate before to_le()) - #52878 (Fix wrong issue number in the test name) - #52883 (Include lifetime in mutability suggestion in NLL messages) - #52904 (NLL: sort diagnostics by span) - #52905 (Fix a typo in unsize.rs) - #52907 (NLL: On "cannot move out of type" error, print original before rewrite) - #52908 (Use SetLenOnDrop in Vec::truncate()) - #52914 (Only run the sparc-abi test on sparc) - #52918 (Backport 1.27.2 release notes) - #52929 (Update compatibility note for 1.28.0 to be correct) Failed merges: - #52758 (Cleanup for librustc::session) - #52799 (Use BitVector for global sets of AttrId) r? @ghost

…r=QuietMisdreavus Cleanup some rustdoc code Commits are mostly individual though some do depend on others.

@ghost

Rollup of 30 pull requests Successful merges: - #52340 (Document From trait implementations for OsStr, OsString, CString, and CStr) - #52628 (Cleanup some rustdoc code) - #52732 (Remove unstable and deprecated APIs) - #52745 (Update clippy to latest master) - #52771 (Clarify thread::park semantics) - #52778 (Improve readability of serialize.rs) - #52810 ([NLL] Don't make "fake" match variables mutable) - #52821 (pretty print for std::collections::vecdeque) - #52822 (Fix From<LocalWaker>) - #52824 (Fix -Wpessimizing-move warnings in rustllvm/PassWrapper) - #52825 (Make sure #47772 does not regress) - #52831 (remove references to AUTHORS.txt file) - #52842 (update comment) - #52846 (Add timeout to use of `curl` in bootstrap.py.) - #52851 (Make the tool_lints actually usable) - #52853 (Improve bootstrap help on stages) - #52859 (Use Vec::extend in SmallVec::extend when applicable) - #52861 (Add targets for HermitCore (https://hermitcore.org) to the Rust compiler and port libstd to it.) - #52867 (releases.md: fix 2 typos) - #52870 (Implement Unpin for FutureObj and LocalFutureObj) - #52876 (run-pass/const-endianness: negate before to_le()) - #52878 (Fix wrong issue number in the test name) - #52883 (Include lifetime in mutability suggestion in NLL messages) - #52888 (Use suggestions for shell format arguments) - #52904 (NLL: sort diagnostics by span) - #52905 (Fix a typo in unsize.rs) - #52907 (NLL: On "cannot move out of type" error, print original before rewrite) - #52914 (Only run the sparc-abi test on sparc) - #52918 (Backport 1.27.2 release notes) - #52929 (Update compatibility note for 1.28.0 to be correct) Failed merges: r? @ghost

rust-highfive assigned steveklabnik Jul 22, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2018

Mark-Simulacrum force-pushed the rustdoc-cleanup-1 branch from c0a51b6 to de5ae62 Compare July 22, 2018 21:04

Mark-Simulacrum force-pushed the rustdoc-cleanup-1 branch from de5ae62 to 39996c8 Compare July 22, 2018 21:58

Mark-Simulacrum force-pushed the rustdoc-cleanup-1 branch from 39996c8 to 40e414a Compare July 28, 2018 23:04

This comment has been minimized.

Sign in to view

Mark-Simulacrum force-pushed the rustdoc-cleanup-1 branch from 40e414a to d0683fb Compare July 28, 2018 23:30

Mark-Simulacrum added 6 commits July 31, 2018 11:37

Provide warnings for invalid code blocks in markdown files

ad40e45

Previously we would only warn on Rust code but we can also do so when testing markdown (the diag::Handler is available).

Provide test configuration through struct

de5cebd

This is far more sound than passing many different arguments of the same type.

Remove dependency on error handling from find_testable_code

03e34f8

Further extract error code switch

01d9555

Removes dependency on UnstableFeatures from markdown rendering

Format code for easier editing

2216db9

Mark-Simulacrum force-pushed the rustdoc-cleanup-1 branch from e5deafc to 67e699f Compare July 31, 2018 17:42

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 31, 2018

Mark-Simulacrum added 4 commits July 31, 2018 17:55

Remove global derive_id and reset_ids functions

7bea518

Previously these functions relied on TLS but we can instead thread the relevant state through explicitly.

Cleanup highlighting code

8e65a46

Removes some unused code and de-publicizes structs

Add dyn to Write

4cd0047

Fixup test case

0f680b3

Mark-Simulacrum force-pushed the rustdoc-cleanup-1 branch from 67e699f to 0f680b3 Compare July 31, 2018 23:55

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2018

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Aug 1, 2018

Rollup merge of rust-lang#52628 - Mark-Simulacrum:rustdoc-cleanup-1, …

e292913

…r=QuietMisdreavus Cleanup some rustdoc code Commits are mostly individual though some do depend on others.

Mark-Simulacrum mentioned this pull request Aug 1, 2018

Rollup of 31 pull requests #52931

Closed

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 1, 2018

Rollup merge of rust-lang#52628 - Mark-Simulacrum:rustdoc-cleanup-1, …

03df573

…r=QuietMisdreavus Cleanup some rustdoc code Commits are mostly individual though some do depend on others.

pietroalbini mentioned this pull request Aug 1, 2018

Rollup of 30 pull requests #52937

Merged

bors merged commit 0f680b3 into rust-lang:master Aug 1, 2018

Mark-Simulacrum deleted the rustdoc-cleanup-1 branch June 8, 2019 13:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup some rustdoc code #52628

Cleanup some rustdoc code #52628

Mark-Simulacrum commented Jul 22, 2018

rust-highfive commented Jul 22, 2018

rust-highfive commented Jul 22, 2018

rust-highfive commented Jul 22, 2018

rust-highfive commented Jul 22, 2018

steveklabnik commented Jul 23, 2018 •

edited

Loading

GuillaumeGomez commented Jul 23, 2018

Mark-Simulacrum commented Jul 23, 2018

QuietMisdreavus commented Jul 23, 2018

Mark-Simulacrum commented Jul 23, 2018

Mark-Simulacrum commented Jul 28, 2018

This comment has been minimized.

rust-highfive commented Jul 29, 2018

rust-highfive commented Jul 29, 2018

GuillaumeGomez commented Jul 29, 2018

QuietMisdreavus commented Jul 31, 2018

Mark-Simulacrum commented Jul 31, 2018

bors commented Jul 31, 2018

rust-highfive commented Jul 31, 2018

Mark-Simulacrum commented Jul 31, 2018

Mark-Simulacrum commented Jul 31, 2018

bors commented Jul 31, 2018

Cleanup some rustdoc code #52628

Cleanup some rustdoc code #52628

Conversation

Mark-Simulacrum commented Jul 22, 2018

rust-highfive commented Jul 22, 2018

rust-highfive commented Jul 22, 2018

rust-highfive commented Jul 22, 2018

rust-highfive commented Jul 22, 2018

steveklabnik commented Jul 23, 2018 • edited Loading

GuillaumeGomez commented Jul 23, 2018

Mark-Simulacrum commented Jul 23, 2018

QuietMisdreavus commented Jul 23, 2018

Mark-Simulacrum commented Jul 23, 2018

Mark-Simulacrum commented Jul 28, 2018

This comment has been minimized.

rust-highfive commented Jul 29, 2018

rust-highfive commented Jul 29, 2018

GuillaumeGomez commented Jul 29, 2018

QuietMisdreavus commented Jul 31, 2018

Mark-Simulacrum commented Jul 31, 2018

bors commented Jul 31, 2018

rust-highfive commented Jul 31, 2018

Mark-Simulacrum commented Jul 31, 2018

Mark-Simulacrum commented Jul 31, 2018

bors commented Jul 31, 2018

steveklabnik commented Jul 23, 2018 •

edited

Loading