Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused code in rustdoc #52630

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Delete unused code in rustdoc #52630

merged 1 commit into from
Jul 31, 2018

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Jul 22, 2018 •
edited
Loading

Also hid the unused crate exports of rustdoc. This is technically a breaking change but we don't even ship librustdoc in the sysroot so I don't expect breakage.

@rust-highfive
Copy link
Collaborator

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2018
@Mark-Simulacrum Mark-Simulacrum changed the title Delete unused code in rustdoc [WIP] Delete unused code in rustdoc Jul 22, 2018
@Mark-Simulacrum Mark-Simulacrum changed the title [WIP] Delete unused code in rustdoc Delete unused code in rustdoc Jul 22, 2018
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@QuietMisdreavus QuietMisdreavus mentioned this pull request Jul 23, 2018
Merged
@pietroalbini
Copy link
Member

Ping from triage @QuietMisdreavus! This PR needs your review.

@QuietMisdreavus
Copy link
Member

Sorry for missing this one! GitHub is reporting some merge conflicts; can you rebase this? r=me with that done.

@Mark-Simulacrum
Copy link
Member Author

@bors r=QuietMisdreavus

@bors
Copy link
Contributor

bors commented Jul 30, 2018

📌 Commit 620c4fd has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 30, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#52630 - Mark-Simulacrum:rustdoc-cleanup-2, …
a928975 
…r=QuietMisdreavus

Delete unused code in rustdoc

Also hid the unused crate exports of rustdoc. This is technically a breaking change but we don't even ship librustdoc in the sysroot so I don't expect breakage.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 30, 2018
Closed
@bors
Copy link
Contributor

bors commented Jul 31, 2018

⌛ Testing commit 620c4fd with merge d2652f6...

bors added a commit that referenced this pull request Jul 31, 2018
@bors
Auto merge of #52630 - Mark-Simulacrum:rustdoc-cleanup-2, r=QuietMisd…
d2652f6 
…reavus

Delete unused code in rustdoc

Also hid the unused crate exports of rustdoc. This is technically a breaking change but we don't even ship librustdoc in the sysroot so I don't expect breakage.
@bors
Copy link
Contributor

bors commented Jul 31, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing d2652f6 to master...

@bors bors merged commit 620c4fd into rust-lang:master Jul 31, 2018
@Mark-Simulacrum Mark-Simulacrum deleted the rustdoc-cleanup-2 branch June 8, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mark-Simulacrum @rust-highfive @pietroalbini @QuietMisdreavus @bors