Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept Option<Box<$t:ty>> in macro argument #54977

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Accept Option<Box<$t:ty>> in macro argument #54977

merged 1 commit into from
Oct 25, 2018

Conversation

estebank
Copy link
Contributor

Given the following code, compile successfuly:

macro_rules! test {
    (
        fn fun() -> Option<Box<$t:ty>>;
    ) => {
        fn fun(x: $t) -> Option<Box<$t>>
        { Some(Box::new(x)) }
    }
}

test! {
    fn fun() -> Option<Box<i32>>;
}

Fix #25274.

@estebank
Accept Option<Box<$t:ty>> in macro argument
c77a0cf 
Given the following code, compile successfuly:

```
macro_rules! test {
    (
        fn fun() -> Option<Box<$t:ty>>;
    ) => {
        fn fun(x: $t) -> Option<Box<$t>>
        { Some(Box::new(x)) }
    }
}

test! {
    fn fun() -> Option<Box<i32>>;
}
```
@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2018
@estebank

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
bors added a commit that referenced this pull request Oct 10, 2018
@bors
Auto merge of #54977 - estebank:macro-arg-parse, r=<try>
4021bd0 
Accept `Option<Box<$t:ty>>` in macro argument

Given the following code, compile successfuly:

```
macro_rules! test {
    (
        fn fun() -> Option<Box<$t:ty>>;
    ) => {
        fn fun(x: $t) -> Option<Box<$t>>
        { Some(Box::new(x)) }
    }
}

test! {
    fn fun() -> Option<Box<i32>>;
}
```

Fix #25274.
@bors

This comment has been minimized.

Sign in to view
@estebank
Copy link
Contributor Author

@rust-lang/infra can I haz crater run?

@pietroalbini
Copy link
Member

@estebank you should have the rights to start runs by yourself. Check out the docs!

@estebank

This comment has been minimized.

Sign in to view
@craterbot

This comment has been minimized.

Sign in to view
@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2018
@craterbot

This comment has been minimized.

Sign in to view
@kennytm
Copy link
Member

kennytm commented Oct 12, 2018

The commit range seems wrong, should be start=master#5af0bb83044c3fb43d59ad5f49ee5ae1a293901f end=try#4021bd0b3c5815b087d6db10ce461e7e4854ade7. BTW a check-only run should be enough? @estebank

@pietroalbini

This comment has been minimized.

Sign in to view
@craterbot

This comment has been minimized.

Sign in to view
@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Oct 12, 2018
@pietroalbini

This comment has been minimized.

Sign in to view
@craterbot

This comment has been minimized.

Sign in to view
@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2018
@craterbot

This comment has been minimized.

Sign in to view
@craterbot
Copy link
Collaborator

🎉 Experiment pr-54977 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Oct 13, 2018
@estebank
Copy link
Contributor Author

There seem to be no regressions caused by this PR, I believe it'll be safe to merge.

@estebank
Copy link
Contributor Author

@pnkfelix Ping. This is a very small change code-wise.

@pnkfelix
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 24, 2018

📌 Commit c77a0cf has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Oct 24, 2018
@kennytm
Rollup merge of rust-lang#54977 - estebank:macro-arg-parse, r=pnkfelix
f3858f8 
Accept `Option<Box<$t:ty>>` in macro argument

Given the following code, compile successfuly:

```
macro_rules! test {
    (
        fn fun() -> Option<Box<$t:ty>>;
    ) => {
        fn fun(x: $t) -> Option<Box<$t>>
        { Some(Box::new(x)) }
    }
}

test! {
    fn fun() -> Option<Box<i32>>;
}
```

Fix rust-lang#25274.
@kennytm kennytm mentioned this pull request Oct 24, 2018
Closed
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Oct 25, 2018
@pietroalbini
Rollup merge of rust-lang#54977 - estebank:macro-arg-parse, r=pnkfelix
f81e47f 
Accept `Option<Box<$t:ty>>` in macro argument

Given the following code, compile successfuly:

```
macro_rules! test {
    (
        fn fun() -> Option<Box<$t:ty>>;
    ) => {
        fn fun(x: $t) -> Option<Box<$t>>
        { Some(Box::new(x)) }
    }
}

test! {
    fn fun() -> Option<Box<i32>>;
}
```

Fix rust-lang#25274.
@pietroalbini pietroalbini mentioned this pull request Oct 25, 2018
Merged
bors added a commit that referenced this pull request Oct 25, 2018
@bors
Auto merge of #55347 - pietroalbini:rollup, r=pietroalbini
8ec22e7 
Rollup of 22 pull requests

Successful merges:

 - #53507 (Add doc for impl From for Waker)
 - #53931 (Gradually expanding libstd's keyword documentation)
 - #54965 (update tcp stream documentation)
 - #54977 (Accept `Option<Box<$t:ty>>` in macro argument)
 - #55138 (in which unused-parens suggestions heed what the user actually wrote)
 - #55173 (Suggest appropriate syntax on missing lifetime specifier in return type)
 - #55200 (Documents `From` implementations for `Stdio`)
 - #55245 (submodules: update clippy from 5afdf8b to b1d0343)
 - #55247 (Clarified code example in char primitive doc)
 - #55251 (Fix a typo in the documentation of RangeInclusive)
 - #55253 (only issue "variant of the expected type" suggestion for enums)
 - #55254 (Correct trailing ellipsis in name_from_pat)
 - #55269 (fix typos in various places)
 - #55282 (Remove redundant clone)
 - #55285 (Do some copy editing on the release notes)
 - #55291 (Update stdsimd submodule)
 - #55296 (Set RUST_BACKTRACE=0 for rustdoc-ui/failed-doctest-output.rs)
 - #55306 (Regression test for #54478.)
 - #55328 (Fix doc for new copysign functions)
 - #55340 (Operands no longer appear in places)
 - #55345 (Remove is_null)
 - #55348 (Update RELEASES.md after destabilization of non_modrs_mods)

Failed merges:

r? @ghost
@bors bors merged commit c77a0cf into rust-lang:master Oct 25, 2018
@matthewjasper matthewjasper mentioned this pull request Oct 27, 2018
Merged
@estebank estebank deleted the macro-arg-parse branch November 9, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@estebank @rust-highfive @bors @pietroalbini @craterbot @kennytm @pnkfelix