Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression tests for issue #54477. #55469

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

pnkfelix
Copy link
Member

At some point someone may want to revisit PR #53564

it would be really good to have regression tests for #54477 before that happens. :)

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 29, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0438165e:start=1540810153829036941,finish=1540810154845179726,duration=1016142785
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
---

[00:04:24] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:211: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:384: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:474: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:584: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:711: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:739: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:740: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:757: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:779: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:816: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:829: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:859: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:862: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:967: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:1001: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:1103: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:1112: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:1253: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:1256: line longer than 100 chars
[00:04:24] tidy error: /checkout/src/test/run-pass/issues/issue-54477-reduced-1.rs:1272: line longer than 100 chars
[00:04:26] some tidy checks failed
[00:04:26] 
[00:04:26] 
[00:04:26] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:26] 
[00:04:26] 
[00:04:26] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:26] Build completed unsuccessfully in 0:00:46
[00:04:26] Build completed unsuccessfully in 0:00:46
[00:04:26] Makefile:79: recipe for target 'tidy' failed
[00:04:26] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0096d290
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0340d254:start=1540810431490937281,finish=1540810431496515213,duration=5577932
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:354ebbae
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:06f0c142
travis_time:start:06f0c142
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0761e0d8
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

I removed the original file that more completely captured the original
crate's tests, as its source crate
(https://crates.io/crates/collection) is licensed under GPL3, and I
suspect that license is not loose enough for me to put into our repo
under our MIT/Apache licensing.

(Would it be an option to attach the GPL3 licesne to just the one
test? Probably. But do I want to bother with it that that point?
Nope!)
@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 30, 2018

📌 Commit 465cd66 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 1, 2018
…ts, r=nikomatsakis

Regression tests for issue rust-lang#54477.

At some point someone may want to revisit PR rust-lang#53564

it would be really good to have regression tests for rust-lang#54477 before that happens. :)
bors added a commit that referenced this pull request Nov 1, 2018
Rollup of 13 pull requests

Successful merges:

 - #55280 (Add libproc_macro to rust-src distribution)
 - #55469 (Regression tests for issue #54477.)
 - #55504 (Use vec![x; n] instead of iter::repeat(x).take(n).collect())
 - #55522 (use String::from() instead of format!() macro to construct Strings.)
 - #55536 (Pass suggestions as impl Iterator instead of Vec)
 - #55542 (syntax: improve a few allocations)
 - #55558 (Tweak `MatcherPos::matches`)
 - #55561 (Fix double_check tests on big-endian targets)
 - #55573 (Make sure the `aws` executable is in $PATH on macOS)
 - #55574 (Use `SmallVec` within `MoveData`.)
 - #55575 (Fix invalid_const_promotion test on some archs)
 - #55578 (Made doc example of `impl Default for …` use `-> Self` instead of explicit self type)
 - #55582 (Remove unused import copy from publish_toolstate.py)
@bors bors merged commit 465cd66 into rust-lang:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants