Rollup of 13 pull requests #55579
Merged
Rollup of 13 pull requests #55579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed the original file that more completely captured the original crate's tests, as its source crate (https://crates.io/crates/collection) is licensed under GPL3, and I suspect that license is not loose enough for me to put into our repo under our MIT/Apache licensing. (Would it be an option to attach the GPL3 licesne to just the one test? Probably. But do I want to bother with it that that point? Nope!)
`create_matches` creates a `Vec<Rc<Vec<NamedMatch>>>`. Even though all the inner `Vec`s are empty, each one is created separately. This commit changes `create_matches` so it instead creates one empty inner `Vec`, and shares it. The commit also changes `MatcherPos::matches` to a boxed slice, because its length doesn't change.
This avoids some allocations.
On at least AArch64 `llvm.trap` raises SIGTRAP.
Since the enums get optimized down to 1 byte long, the bits set in the usize member don't align with the enums on big-endian machines. Avoid this issue by shrinking the integer member to the same size as the enums.
This reduces allocation counts significantly in a few benchmarks, reducing instruction counts by up to 2%.
…disrt, r=Mark-Simulacrum Add libproc_macro to rust-src distribution Fixes rust-lang#55279
…ts, r=nikomatsakis Regression tests for issue rust-lang#54477. At some point someone may want to revisit PR rust-lang#53564 it would be really good to have regression tests for rust-lang#54477 before that happens. :)
…=oli-obk Use vec![x; n] instead of iter::repeat(x).take(n).collect() It's shorter and possibly easier to optimize.
|
@bors r+ p=10 |
|
📌 Commit c80bba1284422b8917a90a13097d23b70d42b386 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit c80bba1284422b8917a90a13097d23b70d42b386 with merge 66bcd4fef6a636891b9982968ea64d5a12b20863... |
|
💔 Test failed - status-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
use String::from() instead of format!() macro to construct Strings.
…=davidtwco Pass suggestions as impl Iterator instead of Vec This avoids some allocations when throwing errors, making failing faster ^^.
…=kennytm syntax: improve a few allocations Add 2 `reserve`s and a `with_capacity` where the final vector size is known.
…s, r=petrochenkov Tweak `MatcherPos::matches` These changes reduce instruction counts on `sentry-cli-check` incremental builds by up to 2%.
…=michaelwoerister Use `SmallVec` within `MoveData`. This reduces allocation counts significantly in a few benchmarks, reducing instruction counts by up to 2%.
Fix invalid_const_promotion test on some archs On at least AArch64 `llvm.trap` raises SIGTRAP. r? @RalfJung
Make sure the `aws` executable is in $PATH on macOS Fixes rust-lang#55571
…alexcrichton Remove unused import copy from publish_toolstate.py
Fix double_check tests on big-endian targets Since the enums get optimized down to 1 byte long, the bits set in the `usize` member don't align with the `enum` values on big-endian machines. Avoid this issue by shrinking the integer member to the same size as the enums.
Made doc example of `impl Default for …` use `-> Self` instead of explicit self type There is no need to state the explicit type of `self`.
|
📌 Commit f76a8e3 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 1, 2018
Rollup of 13 pull requests Successful merges: - #55280 (Add libproc_macro to rust-src distribution) - #55469 (Regression tests for issue #54477.) - #55504 (Use vec![x; n] instead of iter::repeat(x).take(n).collect()) - #55522 (use String::from() instead of format!() macro to construct Strings.) - #55536 (Pass suggestions as impl Iterator instead of Vec) - #55542 (syntax: improve a few allocations) - #55558 (Tweak `MatcherPos::matches`) - #55561 (Fix double_check tests on big-endian targets) - #55573 (Make sure the `aws` executable is in $PATH on macOS) - #55574 (Use `SmallVec` within `MoveData`.) - #55575 (Fix invalid_const_promotion test on some archs) - #55578 (Made doc example of `impl Default for …` use `-> Self` instead of explicit self type) - #55582 (Remove unused import copy from publish_toolstate.py)
|
☀️ Test successful - status-appveyor, status-travis |
|
📣 Toolstate changed by #55579! Tested on commit 451987d. 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Nov 1, 2018
Tested on commit rust-lang/rust@451987d. Direct link to PR: <rust-lang/rust#55579> 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 💔 rls on windows: test-pass → build-fail (cc @nrc, @rust-lang/infra). 💔 rls on linux: test-pass → build-fail (cc @nrc, @rust-lang/infra).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
MatcherPos::matches#55558 (TweakMatcherPos::matches)awsexecutable is in $PATH on macOS #55573 (Make sure theawsexecutable is in $PATH on macOS)SmallVecwithinMoveData. #55574 (UseSmallVecwithinMoveData.)impl Default for …use-> Selfinstead of explicit self type #55578 (Made doc example ofimpl Default for …use-> Selfinstead of explicit self type)